add StdDev variable change #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganchen39
added a commit
that referenced
this pull request
May 21, 2021
* remove Model class, no longer needed (#1) * remove makeobs (#2) * remove makeobs.x, no longer needed * remove Model class, no longer needed (#1) * Implement Geometry class (#3) * ctest passed for Geometry class * Modified test CMakeLists.txt * Travis's suggested changes completed by Ligang * Travis's suggested changes completed by Ligang * add dummy serializeable interfaces (#5) * add serializable interfaces to State (#8) * replace boost::shared_ptr with std::shared_ptr (#9) * change jcsda repo locations (#10) * Implement state class (#11) * Temporary implememting class State for Travis to check. * Updated State.cc * Updating class State * Updating class State. * Updating class State. * Updating class State. * Finished class State, passed all test. * Passed all test for class State. * fix binary path Co-authored-by: Travis Sluka <travissluka@gmail.com> * Finished class Increment. (#17) * Finished class Increment. * Finished class increment. * Updated increment.yml for class increment. * Updated for class Increment. * add test observations (#22) Merged. * Changed float to double for JEDI, read/write netCDF with float for consistency. (#24) * Create Fields base class for Increment/State (#25) * add MPI support (#26) * add missing ModelAux stubs (#27) * Feature/rename (#28) * rename to umdsst * switch to public jedi repo locations * fix travisci * Implement GetValues (#29) * start GetValues * add level(1) to fields * getvalues working? * Merge class LinearGetValues (#31) * Implemented class LinearGetValues, passed all tests. * minor change of a comment. * add hofx_nomodel test (#32) * add hofx_nomodel test * remove use of external OOPS_TRAPFPE env var, deal with that later * Finished bugfix/ConertToCelsius. (#41) * Finished feature class Covariance. (#42) * fix print in getvalues/lineargetvalues (#45) * Finished Feature/dirac.x (#43) * Implementing dirac.x. * Finished feature dirac.x. * Finishing feature/dirac.x. Co-authored-by: Travis Sluka <travissluka@gmail.com> * Fixed conversion between Celsius and Kelvin. (#46) * Fixed conversion between Celsius and Kelvin. * Finished bugfix/C_K_conversion. * update for ufo::locations change (#47) * Finished Feature/staticbinit.x (#48) * Implementing staticbinit.x * Finished feature/staticbinit.x * Finished feature/staticbinit.x 2nd Time. * keep up with JEDI (#49) * Finished Feature/var.x (#50) * Implementing feature/var.x. * Implementing feature/var.x. * Implementing var.x * Finished feature/var.x. * Finished feature/var.x. * Feature/add mask field (#51) * added landmask.nc * Finished feature/addMaskField. * Finished feature/addMaskField. * Finished feature/addMaskField. * Remove hardcoded 180 and 360. * Finished feature/useLandmask. (#55) * Finished feature/useLandmask. * Finished feature/useLandmask. * Finished feature/useLandmask. * add eckit::Configuration to LinearGetValues constructor (#59) * Add support for horizontally varying correlation lengths (#58) * clean old bump files on test run * manually specify correlation lengths * fix coding norms * fix dependencies of errorcovariance test * add StdDev variable change (#60) * feature/addQC finished (#62) * Finished AddQC, Solved problems with passing vector of pointers of FieldImpl from C to Fortran. * Finishing feature/addQC. * Feature/better landmask (#63) * Test improved landmask. * Finished feature/betterLandmask. * Finished feature/betterLandmask. * update for oops hofx3d (#64) * Misc updates (#65) * convert corr length from gaussian to GC * add "default" var change * update reference answers * fix docker on travisci (#66) * remove GeneralizedDepartures (#67) Approved. * Bugfix/grid issues (#68) * invert lat on netcdf I/O * landmask is explicitly applied to background * flood the test background file * fix landmask/grid in yamls * update reference answers * add cycling script (#69) * Create Model2GeoVaLs class (#70) * fields working for any number of fields * implement Model2GeoVaLs * remove ggmask from Geometry * cleanup * Rossby radius based horizontal correlation lengths (#73) * rossby radius based corr loc, using dummy RR values * kd interpolation in geometry * using rossby radius in covariance * fix tests and coding norms * document interptogeom * add .dat to lfs * fix compile error * support for modules with new ecbuild (#76) * support for module with new ecbuild * use public atlas/fckit * Feature/experiment - Added some initial background of 0.25x0.25 grid. (#77) * Added some 0.25x0.25 files. * Added new initial background for 20120101. * Updated for some initial background of 0.25x025 grid. * Updated initial background of 0.25x0.25 grid. * Updated yml files with correct renamed file names. * Updated to have correct file names. * update most recent stable repo tags Co-authored-by: Logan (Ligang) Chen <ligang.chen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A linear variable change class is added
umdsst::StdDevthat implements the background error variance.Currently it uses a global constant value, using a horizontally varying value should be done in a separate PR.
varanddiracare using a standard devation of 1 so that the answers are the same, a new testtest_umdsst_linearvarchange_stddevuses a standard deviation of 2 so that the various multiplies and inverse multiplies of the interface can be properly tested.partially addresses #56