Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the role of the access code in the URLs #10

Closed
NicMcPhee opened this issue Oct 25, 2018 · 1 comment
Closed

Clarify the role of the access code in the URLs #10

NicMcPhee opened this issue Oct 25, 2018 · 1 comment

Comments

@NicMcPhee
Copy link
Contributor

NicMcPhee commented Oct 25, 2018

There was confusion about where the access code goes in the URL, and in particular what happens if we provide an access code in calls to the Morris web server. It (happily) turns out that our server ignores the access code and the tests work and pass, but that was confusing for some of the students.

We should also say something about reading access codes from etc/access_keys.properties in readAccessKeys(), as well as explaining the need to copy access_keys.properties.sample over to the "secret" version that is ignored by git.

@NicMcPhee
Copy link
Contributor Author

I think this has changed beyond all recognition by now, especially with the switch to environment variables, so I'm going to close this and we can open a new one if there are issues down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant