Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create examples #35

Closed
1 task done
prakaa opened this issue Sep 6, 2022 · 2 comments · Fixed by #44
Closed
1 task done

Create examples #35

prakaa opened this issue Sep 6, 2022 · 2 comments · Fixed by #44
Milestone

Comments

@prakaa
Copy link
Collaborator

prakaa commented Sep 6, 2022

  • Core functionality function docstrings should have, or be linked to examples
@prakaa prakaa added this to the v1.0.0 milestone Sep 6, 2022
@nick-gorman
Copy link
Member

Adding some specific suggestions to this issue. I think in both the Core functionality and API Reference documentation it would be good to have either examples (even if they are just simple ones) or links to examples where the class or functions is used.

@prakaa
Copy link
Collaborator Author

prakaa commented Sep 9, 2022

Thanks @nick-gorman. Agree the core functionality functions could have this. All of those functions have examples in the Quick Start section of the docs, so just a matter of linking the docstrings or other text to them.

As for the API Reference, I'm not sure I agree. It's a "high effort, low gain" thing because it mainly benefits devs rather than all users. And if you are a dev, the class-based structuring of functionality should make it easy to understand how things are used/structured (assuming that the names of functions and classes are appropriate).

For example, see compile_data:

def compile_data(
:

  1. Composed of instantiation of instances, then method calls
  2. If you follow the method calls, you will find the underlying code and any refs to public and/or private funcs
  3. All funcs, regardless of whether they are public or private, are documented

@prakaa prakaa mentioned this issue Sep 13, 2022
@prakaa prakaa mentioned this issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants