Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New language Vietnamese #1027

Closed
amparorvd opened this issue Mar 21, 2019 · 7 comments
Closed

New language Vietnamese #1027

amparorvd opened this issue Mar 21, 2019 · 7 comments
Assignees
@amparorvd
Labels
frontEnd
Milestone
0.3.5

Comments

@amparorvd
Copy link
Collaborator

It is proposed to translate the Ravada to the Vietnamese language
@fv3rdugo
Copy link
Member

fv3rdugo commented Apr 3, 2019

@amparorvd I add Vietnamese in Transifex, you are the coordinator now.

fv3rdugo added a commit that referenced this issue Apr 8, 2019
@fv3rdugo
feat(i18n): Add Vietnamese option
94eaf77 
Issue #1027
@amparorvd
Copy link
Collaborator Author

The Vietnamese translation is ready.
You may have errors in some translations.

@frankiejol
Copy link
Member

@amparorvd can you do a Pull Request ?

@frankiejol frankiejol added this to the 0.3.5 milestone Apr 10, 2019
@fv3rdugo
Copy link
Member

fv3rdugo commented Apr 10, 2019 •
edited
Loading

I indicate the steps to follow. It will be interesting for those who do not have clear steps.

  • Change to this branch
    $ git checkout feat/1027_vi_i18n
  • Download vi.po from Transifex and copy in /lib/Ravada/I18N/vi.po
    $ cp for_use_ravada_enpo_vi.po lib/Ravada/I18N/vi.po Check the destination path!
  • git add lib/Ravada/I18N/vi.po
  • Check your work with> $ git status and $ git diff
    If all it's ok, commit
  • $ git commit -a (indicates the issue with "Issue New language Vietnamese #1027")
    Now, upload to remote repository
  • $ git pull; git push
    If there is no problem, requests the PR, one option is go to the code tab in Github and you can see the button to requests the PR.
    That's all, good luck and enjoy!
    Thanks @amparorvd.

@amparorvd amparorvd mentioned this issue Apr 10, 2019
Merged
@amparorvd
Copy link
Collaborator Author

Everything up-to-date

@fv3rdugo
Copy link
Member

fv3rdugo commented Apr 10, 2019 •
edited
Loading

Sorry I add this step,
git add lib/Ravada/I18N/vi.po
this is the reason to check with git status you would have seen that a file was missing for upload.
If you have new files in repository you must added it with git add <file>
Don't worry first time for everything.

@amparorvd
Copy link
Collaborator Author

It's /I8N with the capital N. I think it is already.

fv3rdugo added a commit that referenced this issue Apr 11, 2019
@fv3rdugo
feat(i18n): Add vi.po
418bb5e 
Issue #1027
fv3rdugo pushed a commit that referenced this issue Apr 11, 2019
@amparorvd @fv3rdugo
feat(i18n): Add Vietnamese option (#1059)
13351d2 
* feat(i18n): Add Vietnamese option

Issue #1027

* feat(i18n): Add vi.po

Issue #1027
fv3rdugo added a commit that referenced this issue Apr 11, 2019
@fv3rdugo
feat(i18n): Add Vietnamese option
660dcf7 
Issue #1027
fv3rdugo added a commit that referenced this issue Apr 11, 2019
@fv3rdugo
feat(i18n): Add vi.po
181e3a9 
Issue #1027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amparorvd amparorvd

Labels
frontEnd
Projects
None yet
Milestone
0.3.5
Development

No branches or pull requests
3 participants
@frankiejol @fv3rdugo @amparorvd