Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table filters missing #819

Open
KMnOFour opened this issue Jun 13, 2021 · 0 comments
Open

Table filters missing #819

KMnOFour opened this issue Jun 13, 2021 · 0 comments
Assignees
Labels
4 - Done bug 🐞 Something isn't working

Comments

@KMnOFour
Copy link
Contributor

Describe the bug
Table filters are missing from all the tables that should have them. Issue is a state issue that was introduced in an earlier PR. The table uses a state var to determine whether to show the headers, and that depends on a another new state var that gets set in the same method. This doesn't give the virtual dom enough time to correctly evaluate the new var before setting the original one, so it's always false.

Updated the code to use the same local variable to set both state vars so they are always in sync.

@KMnOFour KMnOFour added the bug 🐞 Something isn't working label Jun 13, 2021
@KMnOFour KMnOFour self-assigned this Jun 13, 2021
@KMnOFour KMnOFour added this to Backlog in GTAS-UI Kanban via automation Jun 13, 2021
@KMnOFour KMnOFour moved this from Backlog to Review in progress in GTAS-UI Kanban Jun 13, 2021
@KMnOFour KMnOFour moved this from Review in progress to Reviewer approved in GTAS-UI Kanban Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Done bug 🐞 Something isn't working
Projects
GTAS-UI Kanban
Reviewer approved
Development

No branches or pull requests

1 participant