Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add QACERT-11-A QCE screen check #5786

Open
acollad1 opened this issue Oct 17, 2023 · 14 comments
Open

Bug: Add QACERT-11-A QCE screen check #5786

acollad1 opened this issue Oct 17, 2023 · 14 comments
Assignees
Labels
bug Checks ECMPS Phase 1 CAMPD & ECMPS 2.0 tickets QA

Comments

@acollad1
Copy link

acollad1 commented Oct 17, 2023

Issue1:
QA Cert Event modal will let you save an event with a null Monitoring System ID and Component ID
Steps to Recreate:
Barry (3) 1, 2, CS0AAN

  1. Select a configuration from the QA Cert Event Data & Test Extension Exemption Data screen
  2. Add/ Edit a QA Cert Event
  3. Make the Monitoring System ID and Component ID null
  4. Save

Issue 2:
Barry (3) 1, 2, CS0AAN
QA Cert Event modal will let you save an event with a null QA Cert Event Code and Required Test Code
Steps to Recreate:

  1. Select a configuration from the QA Cert Event Data & Test Extension Exemption Data screen
  2. Add/ Edit a QA Cert Event
  3. Make the QA Cert Event Code and Required Test Code null
  4. Save
@acollad1 acollad1 added ECMPS Prod Team Items to be worked on for ECMPS Prod Release bug labels Oct 17, 2023
@acollad1 acollad1 changed the title Bug: QA Cert Event Modal Bug: QA Cert Event Modal Required Fields Oct 17, 2023
@subrataroyCVP subrataroyCVP self-assigned this Oct 20, 2023
@subrataroyCVP
Copy link

We have not implemented any checks for QCE and TEE. We need to talk about if we want to implement these checks.

  • QACERT-4
  • QACERT-5
  • EXTEXEM-3
  • EXTEXEM-4

@JanellC
Copy link

JanellC commented Oct 24, 2023

Based on discussion during DSU on 10/24 this is a low priority bug. Will not fix it now @acollad1

@acollad1 acollad1 added Phase 1 CAMPD & ECMPS 2.0 tickets and removed ECMPS Prod Team Items to be worked on for ECMPS Prod Release labels Nov 14, 2023
@esaber76
Copy link

Confirm if still a bug on dev and stg.

@lgiannini1 lgiannini1 assigned mxtomoto1 and unassigned lgiannini1 Mar 1, 2024
@mxtomoto1
Copy link

mxtomoto1 commented Mar 8, 2024

Issue 1 still present on dev. It appears that the only required fields to create a QA Cert Event are QA Cert Event Code and QA Cert Event Date/Hour. Required Test Code automatically populates with the value 0. In terms of Issue 2, QA Cert Event modal lets one save an event with a null Required Test Code (as it automatically populates with the value 0 once created) but not QA Cert Event Code.
24-3-8_t5786_dev
24-3-8_t5786_dev_2

Behavior is identical on stg.

@annalbrecht
Copy link
Contributor

This ticket is specifically for adding the QCE checks. Requirements are needed.

@annalbrecht annalbrecht changed the title Bug: QA Cert Event Modal Required Fields Bug: Add QCE checking Mar 12, 2024
@annalbrecht annalbrecht changed the title Bug: Add QCE checking Bug: Add QCE screen checks Mar 12, 2024
@annalbrecht annalbrecht added the QA label Mar 12, 2024
@annalbrecht
Copy link
Contributor

Need the list of screen checks that should be running in 2.0. Then check that the list of screen checks is running.

@lgiannini1
Copy link

lgiannini1 commented Apr 1, 2024

List of QCE screen checks from 1.0:

  • QACERT-1 - QA Cert Event Code Valid
  • QACERT-2 - QA Cert Event Date Valid
  • QACERT-3 - QA Cert Event Hour Valid
  • QACERT-4 - QA Cert Event System Valid
  • QACERT-5 - QA Cert Event Component Valid
  • QACERT-6 - QA Cert Event Conditional Begin Date and Hour Valid
  • QACERT-7 - QA Cert Event Completion Test Date and Hour Valid
  • QACERT-8 - QA Cert Event Required Test Code Valid
  • QACERT-9 - QA Cert Event Conditional Begin Hour Consistent with Event Hour
  • QACERT-10 - QA Cert Event Completion Test Hour Consistent with Event and Conditional Hour

List of QCE screen checks currently in 2.0:

  • It doesn't appear that any QACERT screen checks are currently implemented. Entering a null QA Cert Event Code and QA Cert Event Data/Hour return error messages (see screenshot above), but they should be QACERT-1-A, QACERT-2-A, and QACERT-3-A errors.

@lgiannini1 lgiannini1 removed their assignment Apr 4, 2024
@annalbrecht
Copy link
Contributor

Lane: check to make sure these issues would be caught by an evaluation.

QCE Check Specs:
https://ecmps.camdsupport.com/documents/ECMPS%20QA%20and%20Cert%20Check%20Specifications%202022%20Q1.pdf

@lgiannini1 lgiannini1 self-assigned this Apr 4, 2024
@lgiannini1
Copy link

lgiannini1 commented Apr 8, 2024

Able to produce the following QACERT check results:

  • QACERT-4-A
  • QACErT-5-A
  • QACERT-6-B
  • QACERT-7-B
  • QACERT-8-A
  • QACERT-9-A
  • QACERT-10-A
  • QACERT-11-A fires on import of duplicate QA Cert Event, but not if you add one manually in QA Cert module and evaluate.

@annalbrecht
Copy link
Contributor

Add QACERT-11-A as a screen check. User should not be able to manually add a duplicate cert event.

@ergjustin
Copy link

@usmanahmederg
In dev :- I was able to generate the QACERT-11-A error code without making any code changes

Image


Reference:


Image

@usmanahmederg
Copy link

@ergjustin
I'm able to generate the error on my local env as well without making any changes so I think it's working as expected already.

Screenshot 2024-06-21 153143

@lgiannini1
Copy link

Verified on dev. Received a QACERT-11-A screen check result by entering a duplicate QA Cert Event for ORIS 3954, CS0 with the following data:

  • Component ID0CB
  • Cert Event Code 175
  • Required Test Code 9
  • QA Cert Event Date 09/23/2019
  • QA Cert Event Hour 13

@ntknguyen ntknguyen self-assigned this Jul 1, 2024
@ntknguyen
Copy link

ntknguyen commented Jul 8, 2024

Verified receiving QACERT-11-A screen check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Checks ECMPS Phase 1 CAMPD & ECMPS 2.0 tickets QA
Projects
None yet
Development

Successfully merging a pull request may close this issue.