Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annual and Daily function names typo #12

Closed
DillonBergin opened this issue Jan 23, 2023 · 2 comments
Closed

Annual and Daily function names typo #12

DillonBergin opened this issue Jan 23, 2023 · 2 comments

Comments

@DillonBergin
Copy link

Hi! I'm a data journalist who has been using this package off and on for several months, so first I want to say thank you for your work on this wrapper. It's been a huge help and very easy to use.

When I was referencing the vignettes today, I noticed what looks like a typo in the description of "Daily Summary Data (aqs_dailydata_by_)" and "Annual Summary Data (aqs_annualdata_by_)" in the vignettes and README. I think you might have accidentally typed typed "dailydata" and "annualdata" when in fact the function is "dailysummary" and "annualsummary."

I did a quick search and it does look like dailydata and annualdata are used elsewhere in the package, but I believe those are just your naming conventions unrelated to the daily and annual summary functions and their names.

@mccroweyclinton-EPA
Copy link
Collaborator

Thank you for pointing this issue out. If I remember correctly, at one point early in the development of this package those functions were indeed called dailydata, at some point I decided to rename those functions dailysummary to keep the function names and documentation consistent with is stated on the AQS website. This is probably an old artifact from the previous function names.

Thank you for pointing this out.

@DillonBergin
Copy link
Author

No problem, thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants