Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTS_airlines.py not wrapped in function #287

Closed
bl-young opened this issue Oct 28, 2022 · 2 comments
Closed

BTS_airlines.py not wrapped in function #287

bl-young opened this issue Oct 28, 2022 · 2 comments
Assignees
Labels
bug Something isn't working feature branch Issues related to feature branches not impacting master

Comments

@bl-young
Copy link
Collaborator

Importing this module is causing errors due to a required local file

https://github.com/USEPA/flowsa/blob/ghgi-recursive-yaml/flowsa/data_source_scripts/BTS_Airlines.py

with open(f'{settings.sourceconfigpath}BTS_Airlines.yaml') as f:
config = flowsa_yaml.load(f)

This should be wrapped inside a function.

@bl-young bl-young added bug Something isn't working feature branch Issues related to feature branches not impacting master labels Oct 28, 2022
@bl-young
Copy link
Collaborator Author

@matthewlchambers This is causing errors in the github actions, and for us to run things, as we don't have access to the file here: https://github.com/USEPA/flowsa/blob/ghgi-recursive-yaml/flowsa/methods/flowbyactivitymethods/BTS_Airlines.yaml#L7

@matthewlchambers
Copy link
Collaborator

Hahaha, that absolutely should be wrapped in a function. My mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature branch Issues related to feature branches not impacting master
Projects
None yet
Development

No branches or pull requests

2 participants