Marci Driver #475
Merged
Marci Driver #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
reviewed
Jun 10, 2022
Kelvinrr
reviewed
Jun 10, 2022
Kelvinrr
reviewed
Jun 10, 2022
Comment on lines
+188
to
+262
| def sensor_model_version(self): | ||
| """ | ||
| Returns | ||
| ------- | ||
| : int | ||
| ISIS sensor model version | ||
| """ | ||
| return 1 |
There was a problem hiding this comment.
Probably be useful to have some boilerplate for docs here, but adding a boilerplate doc string is probably better than nothing?
amystamile-usgs
approved these changes
Jul 19, 2022
jrcain-usgs
pushed a commit
to jrcain-usgs/ale
that referenced
this pull request
May 19, 2023
* Initial Marci driver for ale * Added Marci tests and corrected comparison function * Added kernel data for use in Marci load tests * Pushed marci ISD for use in loads test * Adds function doc strings to Marci and HiRISE drivers * Updated comparison function and marci load test * Added another set of doc string info * Cached reference frame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Marci driver for use within ISIS. There are changes that need to go into ISIS for this driver to work but this gets it working in ALE.
A small bug was also fixed in the comparison function to handle arrays of strings.