Add Kaguyatc IsisLabel, Naifspice driver #487
Conversation
|
@acpaquette I pulled this PR local to test it on KaguyaTC spiceinited cubes. I am getting the following error from the new driver: Trying <class 'ale.drivers.selene_drivers.KaguyaTcIsisLabelNaifSpiceDriver'>
Failed: Failed to find metakernels. mission: selene, year:2007, versions="latest" spice root = "/isisdata/"Why is the |
|
@jlaura The drivers do not have any kernel selection logic in them. That is the job of SpiceQL. It sounds like you want the IsisLabelIsisSpice driver. |
|
Yup, I realize now that this driver is not going to work either. Thanks for the assist! I do need the ISISSpice ISISLabel driver for these data. |
|
@acpaquette Sorry for the delay! |
…ight exposure duration key
| def boresight_x(self): | ||
| """ | ||
| Returns the x focal plane coordinate of the boresight. | ||
| Expects ikid to be defined. This should be the NAIF integer ID for the |
There was a problem hiding this comment.
Do we needs these expects? The API called doesn't need to know this information because this class has an ikid property. The code is explicit that self.ikid is needed. Maybe these 'expects` in the docstring can be removed?
There was a problem hiding this comment.
They were/are a way to tell people what other properties a property relies on, since many of the properties have default implementations
There was a problem hiding this comment.
I see that, but this is a 3 line function and the code clearly needs the ikid.
* Made isis label spacecraft_clock_start/stop_counts handle keywords with units * Add new kaguya isislabel naifspice driver * Add test and test data for the new kaguya driver * Fixes to kaguyami tests and updated kaguyatc tests * Adds missing kernels for kaguyami test * IsisLabelNaifSpice driver and IsisLabelIsisSpice driver now get the right exposure duration key * Fixes for ISIS, CSM inconsistances * Changed any sct2e call that converted the string to float to scs2e calls * Fixed logging in isd_generate * Fixes inconsistencies between kaguyaTC drivers * Fixed tests * Wrapped all spice functions in not hasattr checks * Removed spacecraft_name override in IsisLabel NaifSpice driver * Fixed up drivers and tests * Fixed haiku like doc string descriptions
Adds the kaguyatcIsisLabelNaifSpice driver to ale for use with ISIS. Also fixes a few issues with the kaguyami load test