-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix for fetchGML_IDs, doc for multiple counties of same name #283
Conversation
GDP merges data for counties of same ID: #282 (comment)
@jread-usgs - checks have passed. please glance at the docs before merging - in particular, i want to make sure you're OK with my slightly hacky use of #' #3) look at the options for county names and FIPS codes
#' counties <- data.frame(STCountyFIPS=query(webgeom(geom='derivative:US_Counties',
#' attribute='STATE,COUNTY,FIPS'), 'values'), stringsAsFactors=FALSE)
#' counties$FIPS=substring(counties$STCountyFIPS, nchar(counties$STCountyFIPS)-4)
#' counties$State=substr(counties$STCountyFIPS, 1, 2)
#' counties$County=substring(counties$STCountyFIPS, 3, nchar(counties$STCountyFIPS)-5) |
match_id <- which(value_names %in% values(.Object)) # CHECK ORDER!!! | ||
gml_id = unlist(lapply(match_id, function(x) getNodeSet(xml,paste0(value_path,'/parent::node()[1]/@gml:id'))[[x]][['id']])) | ||
node_sets <- getNodeSet(xml, paste0(value_path,'/parent::node()')) | ||
node_df <- do.call(rbind, lapply(node_sets, function(x) data.frame( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Can you increment the minor version +1? |
sorry @aappling-usgs I meant patch version...can you update again? |
No description provided.