Test Performance and Review Updates #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdwatkins
approved these changes
Sep 5, 2017
tests/testthat/test-gconfig.R
Outdated
| expect_is(webprocess(), "webprocess") | ||
| }) | ||
|
|
||
| context("Test geoknife connection to GDP") |
There was a problem hiding this comment.
Would it be good to run this test first, so if there is a connection problem that is identified first?
There was a problem hiding this comment.
Sure, I just moved it to the download_result test. That's the first one that runs against the GDP.
There was a problem hiding this comment.
Actually, on second thought, I'll just remove it. I just moved the one thing it's testing uniquely to the test above it.
R/geoknife-generic.R
Outdated
| @@ -117,7 +117,7 @@ parseXMLgeoms <- function(xml){ | |||
| # ignore namespaces | |||
| xpath <- sprintf("//*[local-name()='%s']/*[local-name()='%s']/*[local-name()='%s']",parentKey,childKey,key) | |||
| nodes <- xml2::xml_find_all(xml, xpath, ns = pkg.env$NAMESPACES) | |||
| values <- sapply(nodes,xml2::xml_text) | |||
| values <- xml2::xml_text(nodes) | |||
R/query-webdata-variables.R
Outdated
| values <- sapply( | ||
| xml2::xml_find_all(gcontent(response),'//gdp:shortname'), | ||
| xml2::xml_text) | ||
| values <- xml2::xml_text( |
|
This should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates in here addressing comment on #362 and #361.
I modified the filter that gets sent in an execute request to not use gmlids. This should be an improvement because we don't have to query the WFS for all available values to filter. Fixes #287
The testing updates make tests run a good bit faster, especially when the network is slow. I mostly moved tests around and made local .rds artifacts where it wasn't necessary to call out to the server to initialize objects etc. There are still some tests that do things that are needlessly chatty or touch more data than they need to, I left a few comments to that affect. Happy to revert any and all the test changes, but I think they are a step in the right direction to test the geoknife code rather than the web services. This should fix #359.