Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in the aggregated results and summation of monthly #231

Closed
Farshad171 opened this issue Apr 9, 2018 · 10 comments
Closed

Difference in the aggregated results and summation of monthly #231

Farshad171 opened this issue Apr 9, 2018 · 10 comments

Comments

@Farshad171
Copy link

Hi, I have been using the package quite extensively for my dataset. I feel (if no mistake) that the result from annual aggregation (flux) directly from the package is substantially different for some years than if we simply sum the 12 months result from monthly series obtained from the package. Is there a way to make sure that the package is not giving inconsistent result?

@aappling-usgs
Copy link
Contributor

Hi Farshad, could you supply an example?

@Farshad171
Copy link
Author

Farshad171 commented Apr 9, 2018 via email

@aappling-usgs
Copy link
Contributor

Sorry, I'm not seeing any files attached. And could you also share your relevant code, please, so that I can reproduce the above numbers locally?

@Farshad171
Copy link
Author

Sorry, I sent them via email.
Here they are:

SSRPOUT.xlsx
SSRFlow.xlsx

@aappling-usgs
Copy link
Contributor

Great, and some code to reproduce the issue?

@Farshad171
Copy link
Author

My codes are basically what I have from your paper and just organized in an order for my entire data set for different type of nutrients. Is not anything modified. I start from reading the samples and step by step to the aggregation function. Hope that makes sense.

@aappling-usgs
Copy link
Contributor

You could still save me some time, and I'd appreciate it, if you shared your actual code for TP to generate the numbers you shared above.

@Farshad171
Copy link
Author

Sure, let me rerun and get it organized in a way that makes sense. I will send it to you as soon as done. Thanks

@Farshad171
Copy link
Author

So, I ran the model again for one variable and now the result are perfectly matched. I don't know what happened but the result I initially had the issue with were from few months ago. I will probably rerun all my analysis to make sure there is no inconsistencies. Anyhow, I think it is solved! Sorry for inconvenience and thanks for help :)

@aappling-usgs
Copy link
Contributor

Great, thanks for retrying and sharing the result!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants