chore: Change all remaining it to test (#1224)

Change remaining it to test

Co-authored-by: John Gedeon <940173+gidjin@users.noreply.github.com>
Co-authored-by: John Gedeon <john@truss.works>

src/__tests__/pages/_error.test.tsx

@@ -29,7 +29,7 @@ describe('custom error page', () => {
     render(<CustomError statusCode={1024} />)
   })
 
-  it('renders the custom error page,', () => {
+  test('renders the custom error page,', () => {
     expect(screen.getByRole('heading', { level: 1 })).toHaveTextContent('1024')
     expect(screen.getByRole('heading', { level: 2 })).toHaveTextContent(
       'Houston, we have a problem'
@@ -39,7 +39,7 @@ describe('custom error page', () => {
     )
   })
 
-  it('renders a back button', async () => {
+  test('renders a back button', async () => {
     const user = userEvent.setup()
 
     const backButton = screen.getByRole('button', {
@@ -51,7 +51,7 @@ describe('custom error page', () => {
     expect(mockBack).toHaveBeenCalled()
   })
 
-  it('renders feedback links', async () => {
+  test('renders feedback links', async () => {
     const feedbackLink = screen.getByText('feedback@ussforbit.us')
     expect(feedbackLink).toBeVisible()
     expect(feedbackLink).toHaveAttribute('href')
@@ -71,7 +71,7 @@ describe('custom error page', () => {
     )
   })
 
-  it('tests getInitialProps', async () => {
+  test('tests getInitialProps', async () => {
     const getInitialProps = CustomError.getInitialProps
     expect(getInitialProps).toBeDefined()
     expect(getInitialProps).toBeInstanceOf(Function)
@@ -82,7 +82,7 @@ describe('custom error page', () => {
     expect(result).toEqual({ statusCode: 404 })
   })
 
-  it('tests getInitialProps with no statusCode', async () => {
+  test('tests getInitialProps with no statusCode', async () => {
     const getInitialProps = CustomError.getInitialProps
     expect(getInitialProps).toBeDefined()
     expect(getInitialProps).toBeInstanceOf(Function)
@@ -145,7 +145,7 @@ describe('custom error page without status code', () => {
     render(<CustomError />)
   })
 
-  it('renders the custom error page,', () => {
+  test('renders the custom error page,', () => {
     expect(screen.getByRole('heading', { level: 1 })).toHaveTextContent('500')
   })
 })

src/__tests__/pages/login-notice.test.tsx

@@ -11,22 +11,22 @@ describe('LoginNotice page', () => {
     render(<LoginNotice />)
   })
 
-  it('renders the login notice', () => {
+  test('renders the login notice', () => {
     expect(screen.getByRole('heading', { level: 3 })).toHaveTextContent(
       'Notice'
     )
   })
 
-  it('renders the agree button', () => {
+  test('renders the agree button', () => {
     expect(screen.getByRole('link')).toHaveTextContent('I agree')
   })
 
-  it('returns the LoginLayout in getLayout', () => {
+  test('returns the LoginLayout in getLayout', () => {
     const page = 'page'
     expect(LoginNotice.getLayout(page)).toEqual(<LoginLayout>page</LoginLayout>)
   })
 
-  it('returns the expected props in getServerSideProps', async () => {
+  test('returns the expected props in getServerSideProps', async () => {
     const response = await getStaticProps()
     expect(response).toEqual({
       props: {

src/__tests__/pages/update-browser.test.tsx

@@ -15,7 +15,7 @@ describe('Update browser page', () => {
     render(<UpdateBrowser />)
   })
 
-  it('renders the update browser page,', () => {
+  test('renders the update browser page,', () => {
     expect(screen.getByRole('heading', { level: 2 })).toHaveTextContent(
       'I’m sorry, Dave. I’m afraid you can’t use that outdated browser.'
     )
@@ -34,7 +34,7 @@ describe('Update browser page', () => {
     ).toHaveAttribute('href', FIREFOX_DOWNLOAD)
   })
 
-  it('has no a11y violations', async () => {
+  test('has no a11y violations', async () => {
     // Bug with NextJS Link + axe :(
     // https://github.com/nickcolley/jest-axe/issues/95#issuecomment-758921334
     await act(async () => {
@@ -43,7 +43,7 @@ describe('Update browser page', () => {
     })
   })
 
-  it('returns the ErrorLayout in getLayout', () => {
+  test('returns the ErrorLayout in getLayout', () => {
     const page = 'page'
     expect(UpdateBrowser.getLayout(page)).toEqual(
       <ErrorLayout hideNav={true} ieCompat={true}>
@@ -52,7 +52,7 @@ describe('Update browser page', () => {
     )
   })
 
-  it('returns the expected props in getServerSideProps', async () => {
+  test('returns the expected props in getServerSideProps', async () => {
     const response = await getStaticProps()
     expect(response).toEqual({
       props: {

src/components/AnnouncementDate/AnnouncementDate.test.tsx

@@ -9,7 +9,7 @@ import React from 'react'
 import AnnouncementDate from './AnnouncementDate'
 
 describe('AnnouncementDate component', () => {
-  it('renders the component', () => {
+  test('renders the component', () => {
     render(<AnnouncementDate date="2022-05-17T13:44:39.796Z" />)
 
     expect(screen.getByText('17 MAY')).toBeInTheDocument()

src/components/ArticleDateIcon/ArticleDateIcon.test.tsx

@@ -9,20 +9,20 @@ import React from 'react'
 import { ArticleDateIcon } from './ArticleDateIcon'
 
 describe('ArticleDateIcon component', () => {
-  it('renders the given date', async () => {
+  test('renders the given date', async () => {
     const testDate = new Date('May 16 2022')
     render(<ArticleDateIcon date={testDate} />)
     expect(screen.getByText('May')).toBeInTheDocument()
     expect(screen.getByText('16')).toBeInTheDocument()
   })
 
-  it('has no a11y violations', async () => {
+  test('has no a11y violations', async () => {
     const testDate = new Date('May 16 2022')
     const { container } = render(<ArticleDateIcon date={testDate} />)
     expect(await axe(container)).toHaveNoViolations()
   })
 
-  it('renders null if the given date is invalid', async () => {
+  test('renders null if the given date is invalid', async () => {
     const invalidDate = 'May 16 2022' as unknown as Date
     const result = render(<ArticleDateIcon date={invalidDate} />)
 

src/components/ArticleList/ArticleList.test.tsx

@@ -21,14 +21,14 @@ const testArticle = {
 const testArticles = [testArticle, testArticle, testArticle]
 
 describe('ArticleList component', () => {
-  it('renders a list of articles', () => {
+  test('renders a list of articles', () => {
     render(<ArticleList articles={testArticles} />)
 
     expect(screen.getByRole('list')).toBeInTheDocument()
     expect(screen.getAllByRole('listitem')).toHaveLength(3)
   })
 
-  it('displays the Pagination component if pagination props are passed in', async () => {
+  test('displays the Pagination component if pagination props are passed in', async () => {
     render(
       <ArticleList
         articles={testArticles}
@@ -43,7 +43,7 @@ describe('ArticleList component', () => {
     expect(screen.getByRole('link', { name: 'Page 2' })).toBeInTheDocument()
   })
 
-  it('has no a11y violations', async () => {
+  test('has no a11y violations', async () => {
     // Bug with NextJS Link + axe :(
     // https://github.com/nickcolley/jest-axe/issues/95#issuecomment-758921334
     await act(async () => {
@@ -52,7 +52,7 @@ describe('ArticleList component', () => {
     })
   })
 
-  it('renders an empty state', () => {
+  test('renders an empty state', () => {
     render(<ArticleList articles={[]} />)
 
     expect(screen.queryByRole('list')).not.toBeInTheDocument()

src/components/ArticleListItem/ArticleListItem.test.tsx

@@ -32,7 +32,7 @@ const rssTestArticle = {
 }
 
 describe('ArticleListItem component', () => {
-  it('renders the article preview of a cms article', () => {
+  test('renders the article preview of a cms article', () => {
     render(<ArticleListItem article={cmsTestArticle} />)
 
     expect(screen.getByText('May')).toBeInTheDocument()
@@ -43,7 +43,7 @@ describe('ArticleListItem component', () => {
     expect(screen.getByText('CMS Test Label')).toBeInTheDocument()
   })
 
-  it('cms article has no a11y violations', async () => {
+  test('cms article has no a11y violations', async () => {
     // Bug with NextJS Link + axe :(
     // https://github.com/nickcolley/jest-axe/issues/95#issuecomment-758921334
     await act(async () => {
@@ -52,7 +52,7 @@ describe('ArticleListItem component', () => {
     })
   })
 
-  it('renders the article preview of an rss article', () => {
+  test('renders the article preview of an rss article', () => {
     render(<ArticleListItem article={rssTestArticle} />)
 
     expect(screen.getByText('Aug')).toBeInTheDocument()
@@ -63,7 +63,7 @@ describe('ArticleListItem component', () => {
     expect(screen.getByText(rssTestArticle.sourceName)).toBeInTheDocument()
   })
 
-  it('rss article has no a11y violations', async () => {
+  test('rss article has no a11y violations', async () => {
     // Bug with NextJS Link + axe :(
     // https://github.com/nickcolley/jest-axe/issues/95#issuecomment-758921334
     await act(async () => {
@@ -72,7 +72,7 @@ describe('ArticleListItem component', () => {
     })
   })
 
-  it('renders the article preview of an rss article', () => {
+  test('renders the article preview of an rss article', () => {
     render(<ArticleListItem article={rssTestArticle} />)
 
     expect(screen.getByText('Aug')).toBeInTheDocument()

src/components/BreadcrumbNav/BreadcrumbNav.test.tsx

@@ -25,15 +25,15 @@ describe('BreadcrumbNav component', () => {
     render(<BreadcrumbNav navItems={navItems} />)
   })
 
-  it('renders links for the non-current nav items', () => {
+  test('renders links for the non-current nav items', () => {
     const links = screen.getAllByRole('link')
 
     expect(links).toHaveLength(1)
     expect(links[0]).toHaveAttribute('href', navItems[0].path)
     expect(links[0]).toHaveTextContent(navItems[0].label)
   })
 
-  it('renders the current item as static text', () => {
+  test('renders the current item as static text', () => {
     expect(screen.getByText('News & Announcements')).toBeInstanceOf(
       HTMLLIElement
     )

src/components/Collection/Collection.test.tsx

@@ -29,18 +29,18 @@ describe('Collection component', () => {
       )
     })
 
-    it('renders a title', () => {
+    test('renders a title', () => {
       const title = screen.getByRole('heading', { level: 2 })
       expect(title).toHaveTextContent('Example collection')
     })
 
-    it('renders its children in a list', () => {
+    test('renders its children in a list', () => {
       expect(screen.getByRole('list')).toBeInTheDocument()
       expect(screen.getAllByRole('listitem')).toHaveLength(3)
       expect(screen.getAllByRole('link')).toHaveLength(3)
     })
 
-    it('has no a11y violations', async () => {
+    test('has no a11y violations', async () => {
       // Bug with NextJS Link + axe :(
       // https://github.com/nickcolley/jest-axe/issues/95#issuecomment-758921334
       await act(async () => {
@@ -49,7 +49,7 @@ describe('Collection component', () => {
     })
   })
 
-  it('can render a single child', async () => {
+  test('can render a single child', async () => {
     html = render(
       <Collection title="Example collection">
         <Bookmark key="link1" href="#">
@@ -67,7 +67,7 @@ describe('Collection component', () => {
     })
   })
 
-  it('can render a footer node', async () => {
+  test('can render a footer node', async () => {
     const testFooter = <p>Collection footer</p>
 
     html = render(