Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change all remaining it to test #1224

Merged
merged 3 commits into from
Mar 7, 2024
Merged

chore: Change all remaining it to test #1224

merged 3 commits into from
Mar 7, 2024

Conversation

jcbcapps
Copy link
Contributor

@jcbcapps jcbcapps commented Mar 5, 2024

SC-###

Proposed changes

All engineers previously agreed to use the test prefix as opposed to it for all unit tests. We have been updating each file as we touch it, but now that we are handing the project off, this PR changes all remaining tests to follow the previously established convention.


Reviewer notes

Setup

Start the system

yarn services:up
yarn dev
cd ../ussf-portal-cms
yarn dev

Login to the portal http://localhost:3000

Start storybook

yarn storybook

Login to storybook http://localhost:6006, though the command above should open it for you


Code review steps

As the original developer, I have

  • Met the acceptance criteria
  • Created new stories in Storybook if applicable
  • Created/modified automated unit tests in Jest
  • Created/modified automated E2E tests
  • Followed guidelines for zero-downtime deploys, if applicable
  • Use ANDI to check for basic a11y issues

As a reviewer, I have

Check out our How to review a pull request document.


Screenshots

@jcbcapps jcbcapps requested a review from a team as a code owner March 5, 2024 19:58
@gidjin gidjin merged commit 9211e0a into main Mar 7, 2024
11 checks passed
@gidjin gidjin deleted the jc-it-to-test branch March 7, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants