feat: Display Spaceforce.mil news articles below the news carousel #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See for where the solution came from DefinitelyTyped/DefinitelyTyped#35572 (comment)
|
This pull request has been linked to Shortcut Story #772: Finish News & Announcements page. |
abbyoung
reviewed
Aug 17, 2022
abbyoung
reviewed
Aug 17, 2022
|
@jcbcapps this all looks good. The only thing I believe that needs to change is the CTA label to "View Details" |
gidjin
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
This PR is dependent on #744 correct? If so it looks good to me, though I think you may have some updates to apply once #744 is merged. I'm marking it approved assuming that those updates happen :)
Note: I saw John's comment about View Detail but the Figma designs for #744 show View article which is what is on the other branch iirc.
abbyoung
approved these changes
Aug 23, 2022
Merged
gidjin
added a commit
that referenced
this pull request
Aug 24, 2022
## [4.7.0](4.6.0...4.7.0) (2022-08-24) ### Features * Add internal news carousel for news and announcements page ([#744](#744)) ([c4acfe6](c4acfe6)), closes [/github.com/DefinitelyTyped/DefinitelyTyped/issues/35572#issuecomment-498242139](https://github.com/USSF-ORBIT//github.com/DefinitelyTyped/DefinitelyTyped/issues/35572/issues/issuecomment-498242139) * Display Spaceforce.mil news articles below the news carousel ([#746](#746)) ([e13b57a](e13b57a)), closes [/github.com/DefinitelyTyped/DefinitelyTyped/issues/35572#issuecomment-498242139](https://github.com/USSF-ORBIT//github.com/DefinitelyTyped/DefinitelyTyped/issues/35572/issues/issuecomment-498242139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-771
Proposed changes
Reviewer notes
Note: this PR is built off of SC-589, so please review that PR first
Another note: I updated an e2e test in this repo, but also updated it in the
ussf-portalrepo and created a PR there. Please review that PR in tandem with this one.Third and final note (hopefully): This branch also includes the (very few) updates needed to finish SC-772 so please give that story a glance.
Navigate to
/news-announcementsView older Spaceforce.mil articlesand that when clicked, takes you tohttps://www.spaceforce.mil/Newsin a new tabSetup
Make sure to have both the CMS and the portal client running on your local machine. You can do this by
yarn services:up && yarn devin the CMS repo andyarn devin the portal client with this branch checked outCode review steps
As the original developer, I have
As code reviewer(s), I have
As a designer reviewer, I have
As a test user, I have