Fix for remap==False #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting grid are not identical, raises error if resolutions do not match
| @@ -237,6 +237,16 @@ def gen_uh_init(config_file): | |||
| log.error('RVIC parameter generation requires REMAP option to be True' | |||
| ' if AGGREGATE is True') | |||
| raise ValueError('Invalid option') | |||
|
|
|||
| # If remap is False, then the resolution needs to match the routing data | |||
There was a problem hiding this comment.
This should be addressed in the documentation as well.
|
|
|
|
|
|
|
@bartnijssen, this is ready to merge. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow remap==False if grid resolution matches but domain grid and routing grid are not identical, raises error if resolutions do not match
fixes #36