Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remap=False may be broken #36

Closed
jhamman opened this issue Nov 18, 2014 · 2 comments
Closed

remap=False may be broken #36

jhamman opened this issue Nov 18, 2014 · 2 comments

Comments

@jhamman
Copy link
Member

jhamman commented Nov 18, 2014

test raises:
local variable 'full_time_length' referenced before assignment
when remap=False.

Needs further investigation. May just be a error in the test module.

@jhamman jhamman self-assigned this Nov 18, 2014
@jhamman jhamman added this to the RVIC.1.0.3 milestone Nov 18, 2014
@jhamman jhamman modified the milestones: RVIC.1.1.0, RVIC.1.0.3 Mar 26, 2015
@jhamman
Copy link
Member Author

jhamman commented Mar 26, 2015

moving to 1.1.0 since that is basically ready.

This was referenced Apr 9, 2015
@jhamman
Copy link
Member Author

jhamman commented Apr 14, 2015

The larger issue here was that I was not correctly handling (or raising an error) cases when the domain grid did not match the routing grid. If you are not using the remap==True option, then you need to be able to map the routing grid to the domain grid. All the pieces were in place for this so #60 takes care of that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant