This repository has been archived by the owner on May 4, 2022. It is now read-only.
fix(license): Acknowledge Jianyi Liu contributions via Apache 2 clause 5 #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apereo does not currently have an ICLA on file for @jiayinjx , an already-acknowledged Contributor. Where included her contributions were intentionally Contributed, so at the least they can be licensed directly via Apache2 clause 5 regardless of ICLA status.
That is, in effect, bundle @jiayinjx 's Contributions as an Apache2-licensed bundled dependency. Apache documentation suggests we don't actually have to do anything at all in
LICENSE
to do this.A closer audit might reveal that none of Liu's Contributions remain in the current product. While valued, the original Contributions were modest in scope and the codebase has enjoyed significant implementation churn over time. If Apache2 clause 5 ever turns out to be not good enough, someone can dig into that "there is no currently relevant Contribution needing licensing" hypothesis further. Doing this much in
LICENSE
to acknowledge this situation should leave enough breadcrumbs to allow that future digging if justified and may allow the project to defer worrying further about this wrinkle, possibly forever.There's precedent for this approach in Apereo software, though on my reading including this complexity in
NOTICE
and thereby emphasizing it to upstream software products is not necessary or justified.cf. uPortal-Attic/uportal-app-framework#515 , which does this same licensing tweak for
uPortal-application-framework
.Contributor License Agreement adherence: