Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

fix(license): Acknowledge Jianyi Liu contributions via Apache 2 clause 5 #684

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

apetro
Copy link
Contributor

@apetro apetro commented Sep 5, 2017

Apereo does not currently have an ICLA on file for @jiayinjx , an already-acknowledged Contributor. Where included her contributions were intentionally Contributed, so at the least they can be licensed directly via Apache2 clause 5 regardless of ICLA status.

That is, in effect, bundle @jiayinjx 's Contributions as an Apache2-licensed bundled dependency. Apache documentation suggests we don't actually have to do anything at all in LICENSE to do this.

A closer audit might reveal that none of Liu's Contributions remain in the current product. While valued, the original Contributions were modest in scope and the codebase has enjoyed significant implementation churn over time. If Apache2 clause 5 ever turns out to be not good enough, someone can dig into that "there is no currently relevant Contribution needing licensing" hypothesis further. Doing this much in LICENSE to acknowledge this situation should leave enough breadcrumbs to allow that future digging if justified and may allow the project to defer worrying further about this wrinkle, possibly forever.

There's precedent for this approach in Apereo software, though on my reading including this complexity in NOTICE and thereby emphasizing it to upstream software products is not necessary or justified.

cf. uPortal-Attic/uportal-app-framework#515 , which does this same licensing tweak for uPortal-application-framework.


Contributor License Agreement adherence:

Do not currently have an ICLA on file for this already-acknowledged Contributor. Where included her contributions were intentionally Contributed, so at the least can be licensed directly via Apache2 clause 5 regardless of ICLA status.

A closer audit might reveal that none of Liu's Contributions remain in the current product. If Apache2 clause 5 ever turns out to be not good enough, can dig into that further.
@ChristianMurphy
Copy link
Contributor

📓 angular style conventional commit scopes would classify this as type docs. fix is usually reserved for business logic/code changes.

@apetro
Copy link
Contributor Author

apetro commented Sep 5, 2017

Arguably the product is bugged without this licensing acknowledgement, since ICLA purity is in practice a source of angst. Leaving it as fix: to signal that this is intended to, well, fix that.

@apetro apetro merged commit 8f72ee7 into uPortal-Attic:master Sep 5, 2017
@apetro apetro deleted the ack-jianyi-liu branch September 5, 2017 21:26
@davidmsibley davidmsibley added this to the 6.6.1 milestone Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants