Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the Freedom TypeScript definitions now that multiple module declarations can be merged #501

Closed
trevj opened this issue Oct 22, 2014 · 1 comment
Closed

improve the Freedom TypeScript definitions now that multiple module declarations can be merged #501

trevj opened this issue Oct 22, 2014 · 1 comment
Labels
P2

Comments

@trevj
Copy link
Contributor

trevj commented Oct 22, 2014

Our TypeScript definitions for Freedom have a bunch of TODOs concerning this issue:
microsoft/TypeScript#52

Here's our "top-level" TypeScript definition for Freedom:
https://github.com/uProxy/uproxy-lib/blob/dev/src/freedom/typings/freedom.d.ts#L3

This issue is fixed in the TypeScript 1.1 compiler which we're now using. As we're moving to Freedom 0.6 - which significantly changes certain key things about the freedom object - this might be a good time to discuss how we can improve the TypeScript definitions.
@trevj trevj added this to the v-1.0 Allardice milestone Jul 16, 2015
@trevj
Copy link
Contributor Author

trevj commented Oct 7, 2015

Done, thanks to @jpevarnek's work.

@trevj trevj closed this as completed Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevj