Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV Benchmark PR Workflow #795

Closed
philipc2 opened this issue May 17, 2024 · 2 comments · Fixed by #831
Closed

ASV Benchmark PR Workflow #795

philipc2 opened this issue May 17, 2024 · 2 comments · Fixed by #831
Assignees
Labels
CI Continuous Integration

Comments

@philipc2
Copy link
Member

philipc2 commented May 17, 2024

It would be really useful to have a workflow that runs a series of core benchmarks (or all current benchmarks) on a pull request before merging it, providing a summary of the results.

This would help ensure that issues like #793 could be caught before merging.

This workflow could be triggered by a maintainer (not run on every commit)

@philipc2 philipc2 self-assigned this May 17, 2024
@github-project-automation github-project-automation bot moved this to 📚 Backlog in UXarray Development May 17, 2024
@philipc2 philipc2 added the CI Continuous Integration label May 17, 2024
@kafitzgerald
Copy link
Collaborator

This is on the (mental) to do list for geocat-comp as well. Excited to learn from you all if you get to it first!

FWIW xarray has it set up and there's a nice overview on how to do this here. Sorry if I already shared this - can't recall.

@philipc2
Copy link
Member Author

This is on the (mental) to do list for geocat-comp as well. Excited to learn from you all if you get to it first!

FWIW xarray has it set up and there's a nice overview on how to do this here. Sorry if I already shared this - can't recall.

Thanks for these! Something along the lines of the Xarray one would be exactly what I was envisioning.

@philipc2 philipc2 moved this from 📚 Backlog to 📝 To-Do in UXarray Development May 19, 2024
@philipc2 philipc2 linked a pull request Jul 2, 2024 that will close this issue
@philipc2 philipc2 moved this from 📝 To-Do to 🏗 In progress in UXarray Development Jul 2, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in UXarray Development Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants