Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Magni robot simulation in Gazebo. #70

Merged
merged 5 commits into from
Feb 23, 2019
Merged

Updates for Magni robot simulation in Gazebo. #70

merged 5 commits into from
Feb 23, 2019

Conversation

Polonium19
Copy link
Collaborator

@Polonium19 Polonium19 commented Feb 16, 2019 •
edited by rohbotics
Loading

Magni robot simulation in Gazebo:

  • Gazebo package added.
  • URDF description update.

Edit (@rohbotics): Closes #69

@rohbotics
Copy link
Member

Thanks for the PR Petro.

Trying it out I notice a few problems:

  • cmd_vel and odom are namespaced under /ubiquity_velocity_controller when they should be global
  • The lighting properties for everything but the casters seems to be wrong, as it is all dark
  • There are merge conflicts, so you will have to rebase your commits

Let me know if you need any help fixing those.

Looking forward to seeing sonar support.

@rohbotics rohbotics self-requested a review February 17, 2019 06:21
rohbotics
rohbotics requested changes Feb 17, 2019
View reviewed changes
magni_description/urdf/inertial.xacro Outdated Show resolved Hide resolved
magni_description/urdf/inertial.xacro Outdated Show resolved Hide resolved
magni_gazebo/config/magni_controllers.yaml Outdated Show resolved Hide resolved
@ghost ghost assigned Polonium19 Feb 18, 2019
@Polonium19
Copy link
Collaborator Author

Please check updates for the PR.

@rohbotics
Copy link
Member

These changes look good thank you. Please add the sensor support.

@rohbotics rohbotics mentioned this pull request Feb 23, 2019
Merged
@rohbotics rohbotics merged commit 783b4b5 into UbiquityRobotics:indigo-devel Feb 23, 2019
@ghost ghost removed the in progress label Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohbotics rohbotics rohbotics approved these changes

Assignees

@Polonium19 Polonium19

Labels
None yet
Projects
UbiquityRobotics/ubiquity_main
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Polonium19 @rohbotics