Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensors simulation implemented for Gazebo. #75

Merged
merged 7 commits into from
Feb 24, 2019
Merged

Sensors simulation implemented for Gazebo. #75

merged 7 commits into from
Feb 24, 2019

Conversation

Polonium19
Copy link
Collaborator

Added sensors simulation models

  • Ultrasonic sonars
  • Rospi camera

@ghost ghost assigned Polonium19 Feb 22, 2019
@ghost ghost added the in progress label Feb 22, 2019
@rohbotics
Copy link
Member

@Polonium19, does this replace #70?

rohbotics
rohbotics requested changes Feb 23, 2019
View reviewed changes
Copy link
Member

@rohbotics rohbotics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, couple minor issues:

  • the camera is occluded by the sonar, maybe this is a problem with the measurements of the camera position we had
  • There is also an upward facing camera mode, can you make that a launch argument for the gazebo launch?

magni_gazebo/config/magni_controllers.yaml Outdated Show resolved Hide resolved
magni_description/urdf/sensors/sonar_hc-sr04.xacro Outdated Show resolved Hide resolved
@rohbotics rohbotics merged commit efe9d70 into UbiquityRobotics:indigo-devel Feb 24, 2019
@ghost ghost removed the in review label Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohbotics rohbotics rohbotics approved these changes

Assignees

@Polonium19 Polonium19

Labels
None yet
Projects
UbiquityRobotics/ubiquity_main
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Polonium19 @rohbotics