Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for selecting which camera to use #55
Conversation
rohbotics
added some commits
Oct 19, 2018
rohbotics
self-assigned this
Oct 19, 2018
rohbotics
requested a review
from
jim-v
Oct 19, 2018
wafflebot
bot
added
the
in progress
label
Oct 19, 2018
rohbotics
changed the title
Add supporting to selecting which camera to use
Add support for selecting which camera to use
Oct 19, 2018
rohbotics
added
in review
and removed
in progress
labels
Oct 19, 2018
This comment has been minimized.
This comment has been minimized.
realizator
commented
Oct 19, 2018
•
@rohbotics, camera select option looks good. I will ask my friend with ROS experience if he will be able to use it. Also two notices for you. While working in stereo mode one camera is set as "master", another as "slave", or "secondary". "Master" makes auto settings, and secondary camera copies all settings form master (like brightness, AWB, contrast etc.) for images to be captured with the same settings. If we take independent images we can obtain different settings (especially in a case of light source on the left or right - settings will differ). But for the first stage tests it is not so critical. Second notice for the future. If I work with stereo mode in Pi and make "-cs 1" - second camera became "master", and cameras are "swapped" in final image. That is left became right and vice versa. We should keep it in a mind for the future. |
This comment has been minimized.
This comment has been minimized.
Here is a deb file to test off of: https://drive.google.com/open?id=1VhjHMQT-46AEUKsidiEA0s1utdU7aw_c To install: To test on our image: Ctrl+C the processes You should see images from different cameras each time. |
jimvaughan
approved these changes
Oct 20, 2018
jimvaughan left a comment
Looks reasonable |
jim-v
approved these changes
Oct 20, 2018
Looks reasonable to me too :) |
This comment has been minimized.
This comment has been minimized.
@realizator can you test this out and let me know if it lets you switch cameras? |
This comment has been minimized.
This comment has been minimized.
Wow Jim is approving so many pull requests it looks like there are two of
him!
:-)
…On Sat, Oct 20, 2018 at 3:46 PM Jim Vaughan ***@***.***> wrote:
***@***.**** approved this pull request.
Looks reasonable to me too :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#55 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALDeViYZsTSZaw39tgphBDxz3YprdXUGks5um6fbgaJpZM4Xvf6b>
.
|
This comment has been minimized.
This comment has been minimized.
realizator
commented
Oct 21, 2018
@rohbotics I will have access to my equipment tomorrow and can check camera selection. Will write you my results right after tests. |
This comment has been minimized.
This comment has been minimized.
realizator
commented
Oct 22, 2018
@rohbotics I tested your DEB.
Just a mention - I have v1 camera (wide-angle clone of original V1), but all your commands for V2 works. |
This comment has been minimized.
This comment has been minimized.
realizator
commented
Oct 22, 2018
p.s. sorry for posting 3 comments - GitHub have some problems now with login and posting comments ("You can't comment at this time."). I deleted duplicated comments. |
This comment has been minimized.
This comment has been minimized.
Awesome! Merging. Yup, my bad on the rqt_image_view command, sorry about that Just FYI |
rohbotics
merged commit 51c4c5b
into
kinetic
Oct 22, 2018
rohbotics
deleted the
camera-select
branch
Oct 22, 2018
wafflebot
bot
removed
the
in review
label
Oct 22, 2018
This comment has been minimized.
This comment has been minimized.
realizator
commented
Oct 23, 2018
upd> @rohbotics , also two notices about tests
|
This comment has been minimized.
This comment has been minimized.
Do you have raw publishing enabled? |
This comment has been minimized.
This comment has been minimized.
realizator
commented
Oct 25, 2018
@rohbotics I tested it with enable_raw, and looks like it works. |
This comment has been minimized.
This comment has been minimized.
amburkoff
commented
Oct 26, 2018
@rohbotics How to simultaneously run two nodes so that one streams the left camera and the other right in different topics? |
rohbotics commentedOct 19, 2018
Related to #41
@realizator Can you see if this at least partially suits your needs?