-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for selecting which camera to use #55
Conversation
@rohbotics, camera select option looks good. I will ask my friend with ROS experience if he will be able to use it. Also two notices for you. While working in stereo mode one camera is set as "master", another as "slave", or "secondary". "Master" makes auto settings, and secondary camera copies all settings form master (like brightness, AWB, contrast etc.) for images to be captured with the same settings. If we take independent images we can obtain different settings (especially in a case of light source on the left or right - settings will differ). But for the first stage tests it is not so critical. Second notice for the future. If I work with stereo mode in Pi and make "-cs 1" - second camera became "master", and cameras are "swapped" in final image. That is left became right and vice versa. We should keep it in a mind for the future. |
Here is a deb file to test off of: https://drive.google.com/open?id=1VhjHMQT-46AEUKsidiEA0s1utdU7aw_c To install: To test on our image: Ctrl+C the processes You should see images from different cameras each time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me too :)
@realizator can you test this out and let me know if it lets you switch cameras? |
Wow Jim is approving so many pull requests it looks like there are two of
him!
:-)
…On Sat, Oct 20, 2018 at 3:46 PM Jim Vaughan ***@***.***> wrote:
***@***.**** approved this pull request.
Looks reasonable to me too :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#55 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALDeViYZsTSZaw39tgphBDxz3YprdXUGks5um6fbgaJpZM4Xvf6b>
.
|
@rohbotics I will have access to my equipment tomorrow and can check camera selection. Will write you my results right after tests. |
@rohbotics I tested your DEB.
Just a mention - I have v1 camera (wide-angle clone of original V1), but all your commands for V2 works. |
p.s. sorry for posting 3 comments - GitHub have some problems now with login and posting comments ("You can't comment at this time."). I deleted duplicated comments. |
Awesome! Merging. Yup, my bad on the rqt_image_view command, sorry about that Just FYI |
upd> @rohbotics , also two notices about tests
|
Do you have raw publishing enabled? |
@rohbotics I tested it with enable_raw, and looks like it works. |
@rohbotics How to simultaneously run two nodes so that one streams the left camera and the other right in different topics? |
I am also interested in this, is it possible? |
Related to #41
@realizator Can you see if this at least partially suits your needs?