-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@deprecated Use the remove() method on the event subscription returned by addEventListener(). #92
Comments
can we get this change in a pr ? |
Any news for this change? :) |
@JakeOrel @rasmusviben @UdaySravanK I tried to make a PR but was unable to launch the example project locally to test it. Right now it only reflects changes proposed by @URvesh109, without testing on my side. I have this error when trying to launch the example project : when executing this command : I have installed the dependencies with yarn, setup my IDE to run JDK15 (and tried JDK1.8 before that, and JDK18 before that). I've been able to build the project (gradle build) but not launching it. Your advices / tests / PR review would be welcome. |
I also got this warning:
|
This issue has been addressed in the latest patch release v1.3.8. Thanks for bringing it up. |
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
rn-swipe-button@1.3.7
for the project I'm working on.Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: