-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PP-502] Method profile corrections #19358
Conversation
This is necessary because the parent definition of the settings has changed
Change default_value to value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
resources/quality/ultimaker_method/um_method_1a_um-pla-175_0.2mm.inst.cfg
Outdated
Show resolved
Hide resolved
resources/quality/ultimaker_method/um_method_1a_um-pla-175_0.2mm.inst.cfg
Outdated
Show resolved
Hide resolved
resources/quality/ultimaker_method/um_method_1c_um-pla-175_0.2mm.inst.cfg
Outdated
Show resolved
Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_labs_um-pla-175_0.2mm.inst.cfg
Outdated
Show resolved
Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_labs_um-abscf-175_0.2mm.inst.cfg
Outdated
Show resolved
Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_2a_um-pva-175_0.2mm.inst.cfg
Show resolved
Hide resolved
raft_interface_speed = 15 | ||
raft_interface_z_offset = -0.05 | ||
raft_interface_z_offset = =-0.1 if raft_base_thickness == 0.5 else -0.05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the exact comparison with 0.5? Seems like a bit of a weird thing, shouldn't it be someting like lower than 0.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paul suggested tying this raft interface logic to a specific raft base value rather than saying "if PVA is paired with N12CF". Although, your comment here made me double check the N12CF file for the raft base height and it was actually set to 0.4 (this is a mistake). So I am going to update this value in the N12CF file to reflect 0.5 instead of 0.4. If there's a better way to reference a specific material pair, let me know and I will update it again. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the formula and it does not switch. Perhaps raft_base_thickness == 0.5 is sensitive to rounding errors
I also tried: =-0.1 if extruderValue(raft_base_extruder_nr, 'material_type') == 'Nylon12 Carbon Fiber' else -0.05
However, that also did not work :-( [resulted in -0.05 for both PLA and Nylon12-CF)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wawanbreton just informed me that this is a bug in Cura that they try to resolve before 5.8 beta
resources/quality/ultimaker_method/um_method_labs_um-pla-175_0.2mm.inst.cfg
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
…te. Removed formulas containing extruder_nr from the def.json files. PP-502
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
Type of change
How Has This Been Tested?
I copied the extruder, definition, variant & quality files into the Beta 5.8 build and checked values in the UI. I also sliced 44 files (1 per Method X & Method XL configuration) that I will be printing over the next few days.
Test Configuration:
Ventura 13.6.6
Checklist: