Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default_value to value #19326

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Change default_value to value #19326

merged 3 commits into from
Jul 9, 2024

Conversation

wawanbreton
Copy link
Contributor

This is necessary because the parent definition of the settings has changed

wawanbreton and others added 2 commits July 5, 2024 13:18
This is necessary because the parent definition of the settings has changed
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/dxu.def.json Show resolved Hide resolved
Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rburema rburema dismissed github-actions[bot]’s stale review July 9, 2024 08:54

Requested changes weren't part of the PR, let's try to keep this small, bot-buddy.

@rburema rburema changed the base branch from main to 5.8 July 9, 2024 08:57
@rburema rburema changed the base branch from 5.8 to main July 9, 2024 08:58
@rburema rburema merged commit 9351096 into main Jul 9, 2024
6 checks passed
@rburema rburema deleted the fix-unit-tests-default_startx branch July 9, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants