Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbabel/wmt22-comet-da model not working as part of Huggingface evaluate #125

Open
alexandremuzio opened this issue Mar 27, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@alexandremuzio
Copy link

alexandremuzio commented Mar 27, 2023

🐛 Bug

I tried using Huggingface evaluate but it is not working with the newest Unbabel/wmt22-comet-da as part of unbabel-comet 2.0.0 release. I'm not sure if this is an issue with Huggingface evaluate lib or COMET.

To Reproduce

Please check this collab notebook.

Screenshots

The issue:

image
.

Environment

OS: Linux
Version 2.0.0

@alexandremuzio alexandremuzio added the bug Something isn't working label Mar 27, 2023
@ricardorei
Copy link
Collaborator

It seems like Hugging face evaluate has to be updated to support recent comet versions. This is a bug on evaluate and not on COMET.

I'll try to find some time to investigate whats wrong with the current implementation of COMET in evaluate.

@ricardorei
Copy link
Collaborator

I created a pull request to evaluate to solve this: huggingface/evaluate#443

Once it is merged, it should work.

Basically it has to do with an API change. You can see the difference here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants