Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: order theory #1716

Closed
nmvdw opened this issue Jun 14, 2023 · 15 comments · Fixed by #1921
Closed

New package: order theory #1716

nmvdw opened this issue Jun 14, 2023 · 15 comments · Fixed by #1921

Comments

@nmvdw
Copy link
Collaborator

nmvdw commented Jun 14, 2023

What do people think of adding a new package called 'OrderTheory' whose contents are as follows:

I think that this way, the filers are ordered more logically.

@benediktahrens
Copy link
Member

Good with me!

@rmatthes
Copy link
Member

rmatthes commented Jun 14, 2023

For me, this proposal implies that the work leading to Pataraia's fixed-point theorem (monotone endofunctions on a pointed DCPO have a fixed point - no continuity needed) in https://github.com/UniMath/UniMath/blob/master/UniMath/Algebra/FixedPointTheorems.v is declared as obsolete - since it will not belong to the package. Currently, I do not see Pataraia's theorem. Is it maybe hidden through more abstraction?

@rmatthes
Copy link
Member

A side question: is that theorem really an original result of Pataraia, or is it rather his proof that brought it into the realm of univalent mathematics? The book by Davey and Priestley (2nd ed.) discusses the statement as "CPO Fixpoint Theorem II". Then they say that previous proofs were known that relied on Zorn's lemma and that Pataraia's proof is "elegant". But that other previous proofs avoided the axiom of choice by using what they call "CPO Fixpoint Theorem III" on increasing self-maps on pointed DCPOs.

@nmvdw
Copy link
Collaborator Author

nmvdw commented Jun 15, 2023

For me, this proposal implies that the work leading to Pataraia's fixed-point theorem (monotone endofunctions on a pointed DCPO have a fixed point - no continuity needed) in https://github.com/UniMath/UniMath/blob/master/UniMath/Algebra/FixedPointTheorems.v is declared as obsolete - since it will not belong to the package. Currently, I do not see Pataraia's theorem. Is it maybe hidden through more abstraction?

Good point. That file should be moved as well to that folder.

@rmatthes
Copy link
Member

And what about the prerequisites for that file?

@m-lindgren
Copy link
Member

I like this idea. I would also be in favor of moving the definitions of po (we should give this a more descriptive name IMO), Poset etc, and their associated functions out of Foundations and MoreFoundations into this new package.

@nmvdw
Copy link
Collaborator Author

nmvdw commented Jun 26, 2023

And what about the prerequisites for that file?

See #1726 for a concrete suggestion on this.

m-lindgren pushed a commit that referenced this issue Jun 29, 2023
This partially deals with:
#1716

The changes are:
- Create a new package 'OrderTheory'
- Move the folders on DCPOs, Posets, and Lattice to OrderTheory
- Move the files Dcpo and FixedPointTheorems
- Add a folder on fixpoint theorems
- Add some material on fixpoint theorems

There is some more factoring to do, because there is material on
OrderTheory in both MoreFoundations and Combinatorics.

Also avoids a bit of low-level reasoning with factor_through_squash 
by Ralph Matthes <ralph.matthes@irit.fr>
@benediktahrens
Copy link
Member

@nmvdw : is this issue solved?

@m-lindgren
Copy link
Member

Related: #1067.

@nmvdw
Copy link
Collaborator Author

nmvdw commented Jul 11, 2023

@nmvdw : is this issue solved?

Not fully yet. There is still some material that needs to be moved to OrderTheory (partial orders, well-founded sets).

@arnoudvanderleer
Copy link
Collaborator

@nmvdw If I understand this correctly, there are exactly two (parts of) files that still need to be moved?

@nmvdw
Copy link
Collaborator Author

nmvdw commented Aug 23, 2024

Yes. The easiest change is to move https://github.com/UniMath/UniMath/blob/master/UniMath/Combinatorics/WellOrderedSets.v and https://github.com/UniMath/UniMath/blob/master/UniMath/Combinatorics/OrderedSets.v, and a more complicated change would be to move the stuff on posets.

@arnoudvanderleer
Copy link
Collaborator

The posets are more complicated because they are scattered through multiple files, or because their file has more references pointing to it?

@nmvdw
Copy link
Collaborator Author

nmvdw commented Aug 23, 2024

I think both.

@arnoudvanderleer
Copy link
Collaborator

I think I'll also move Subposets.v.
Would it also be good to move StructureIdentity.v?

nmvdw added a commit that referenced this issue Sep 6, 2024
Resolves #1716

---------

Co-authored-by: Niels van der Weide <nnmvdw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants