Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlotGeometry fails to plot multiple fill colors #3344

Closed
dcamron opened this issue Jan 2, 2024 · 2 comments · Fixed by #3355
Closed

PlotGeometry fails to plot multiple fill colors #3344

dcamron opened this issue Jan 2, 2024 · 2 comments · Fixed by #3355
Assignees
Labels
Area: Plots Pertains to producing plots Type: Bug Something is not working like it should
Milestone

Comments

@dcamron
Copy link
Member

dcamron commented Jan 2, 2024

PlotGeometry fails to plot multiple fill values as of v1.6. See v1.6 example vs v1.5 example. Reproduced locally, and I see we don't have any image tests with lists of fill colors. I've yet to dive in, but I don't imagine anything too terrifying hiding in there.

@dcamron dcamron added Type: Bug Something is not working like it should Area: Plots Pertains to producing plots labels Jan 2, 2024
@dopplershift dopplershift added this to the January 2024 milestone Jan 3, 2024
@kgoebber
Copy link
Collaborator

kgoebber commented Jan 3, 2024

It is also failing in the stroke color as well.

@kgoebber
Copy link
Collaborator

kgoebber commented Jan 4, 2024

Okay, so I investigated this a bit and the issue comes in updating the kwargs. In this instance we are iterating through values and so the first time through it is setting the default value of the dictionary if it did not exist in the mpl_args attribute, but then can't update the value past that point. In no other of the declarative pieces do we loop through values for plotting purposes, so we might need a unique solution for this portion of the code to ensure that a value given in mpl_args overrides something put in for a given attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants