$this->request->type confusion in Controller::_init #356
Conversation
… a param named 'type' in the request object and not a mistyped instance var or method
$this->request->type confusion in Controller::_init
|
No worries, this is why we have version control. ;-) |
|
Okay, so, that's bizarre: http://travis-ci.org/#!/UnionOfRAD/lithium/jobs/731476 I'm gonna assume that the Memcache stuff is a fluke and unrelated, but it looks like those same tests are failing. I'll pull it down later and see if it works for me locally. |
|
Those look like the fails that happen if there is no Memcache server running. I can reproduce by turning it off on my local. |
|
Look closely and you can see that the 5.4 build is successfully running. Maybe there was an issue with the memcached server when the 5.3 tests were running? this looks completely unrelated to me. Let's wait for the next commit and see what happens. |
|
You can trigger a build manually by clicking on "test hook" in the admin section of the repo (on Github) |
|
That's what I did, and that's what caused it to fail. |
|
Okay, this was totally my bad. There was another commit on dev that was causing tests to fail, and I guess the memcache thing was just a temporary glitch in Travis. Anyway, I cherry-picked onto master. Sorry for all the trouble. |
Retry of #354, this time against the dev branch and without the typo. Not sure how I managed to push a version that didn't pass tests. My only thought is that I deleted my branch and recreated it and introduced a typo when I did that... pretty weak excuse.
Anyway, this passes all tests on my machine.