fix: make header text clickable #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kristiehuang
commented
Aug 8, 2022
| onReviewSwapClick={() => { | ||
| return new Promise((resolve) => resolve(true)) | ||
| }} | ||
| onReviewSwapClick={() => new Promise((resolve) => resolve(true))} |
There was a problem hiding this comment.
unrelated but nit to remove extra brackets
JFrankfurt
reviewed
Aug 9, 2022
src/components/Dialog.tsx
Outdated
| <IconButton color="primary" onClick={useContext(OnCloseContext)} icon={ChevronLeft} /> | ||
| <Row gap={0.5}>{title && <ThemedText.Subhead1>{title}</ThemedText.Subhead1>}</Row> | ||
| </Row> | ||
| <TextButton color="primary" onClick={useContext(OnCloseContext)}> |
There was a problem hiding this comment.
nit: (I know this isn't a part of this PR) - hooks shouldn't be used in the render function
JFrankfurt
approved these changes
Aug 9, 2022
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both left arrow & header text are now clickable in a dialog popup (as per design request)