Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split handlers from controlled state #152

Merged
merged 3 commits into from
Aug 22, 2022
Merged

fix: split handlers from controlled state #152

merged 3 commits into from
Aug 22, 2022

Conversation

zzmp
Copy link
Contributor

@zzmp zzmp commented Aug 19, 2022

  • Treats swap event handlers as separate from the values controlling state
  • Refactors swap event handlers for a cleaner implementation

@zzmp zzmp requested a review from JFrankfurt August 19, 2022 19:03
@vercel
Copy link

vercel bot commented Aug 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
widgets ✅ Ready (Inspect) Visit Preview Aug 19, 2022 at 7:12PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 19, 2022 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview August 19, 2022 19:05 Inactive
@vercel vercel bot temporarily deployed to Preview August 19, 2022 19:12 Inactive
@zzmp zzmp closed this Aug 20, 2022
@zzmp zzmp reopened this Aug 20, 2022
JFrankfurt
JFrankfurt approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@JFrankfurt JFrankfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JFrankfurt JFrankfurt merged commit 27b1985 into main Aug 22, 2022
@zzmp zzmp deleted the split-controlling-handlers branch August 22, 2022 21:23
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFrankfurt JFrankfurt JFrankfurt approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzmp @JFrankfurt