feat: polish controlled component #156

zzmp · 2022-08-22T19:08:22Z

Moves swap state control to a single prop, value
- This mirrors the way that form components are controlled (with a value prop)
- This improves the UX by making it harder to "partially" control the form by thinking all the props are optional
Adds new settings state control under a new prop, settings
- Simplifies settings state and adds appropriate callbacks
Cleans up dead code surrounding settings

vercel · 2022-08-22T19:08:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
widgets	✅ Ready (Inspect)	Visit Preview	Aug 22, 2022 at 7:08PM (UTC)

github-actions · 2022-08-23T19:56:18Z

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zzmp and others added 6 commits August 22, 2022 12:04

chore: nest settings state under swap

7891a55

chore: rm mock toggle

a521e7e

chore: rm unused client side router

596e5d8

feat: controlled value and settings

be6033a

style(lint): lint action with ESLint

1d10447

fix: use callback

a955b44

zzmp requested a review from JFrankfurt August 22, 2022 19:08

vercel bot temporarily deployed to Preview August 22, 2022 19:08 Inactive

zzmp mentioned this pull request Aug 22, 2022

feat: polish controlled component #155

Closed

JFrankfurt approved these changes Aug 22, 2022

View reviewed changes

zzmp merged commit 9d12999 into main Aug 22, 2022

github-actions bot added the released label Aug 23, 2022

zzmp deleted the polish-control branch September 14, 2022 20:24

Provide feedback