feat: always show price impact % #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JFrankfurt
force-pushed
the
update-price-impact-logic
branch
from
24aedc1
to
ebf5068
Compare
zzmp
suggested changes
Aug 22, 2022
| @@ -51,7 +51,7 @@ export function computeRoutes( | |||
| // `Route` constructor may throw if inputs/outputs are temporarily out of sync | |||
| // (RTK-Query always returns the latest data which may not be the right inputs/outputs) | |||
| // This is not fatal and will fix itself in future render cycles | |||
| console.error(e) | |||
| console.error('computeRoutes error', e) | |||
There was a problem hiding this comment.
If this is not fatal, should we log something to console? Or should we only be logging with console.debug?
zzmp
reviewed
Aug 23, 2022
| @@ -85,7 +85,7 @@ export default function Output({ disabled, focused, children }: PropsWithChildre | |||
| <ThemedText.Body2 color="secondary" userSelect> | |||
| <Row> | |||
| <USDC gap={0.5} isLoading={isRouteLoading}> | |||
| {outputUSDC ? `$${formatCurrencyAmount(outputUSDC, 6, 'en', 2)}` : '-'}{' '} | |||
| {outputUSDC && `$${formatCurrencyAmount(outputUSDC, 6, 'en', 2)} `} | |||
There was a problem hiding this comment.
The space at the end of the string literal is intentional, right? I think it's necessary, just double-checking.
There was a problem hiding this comment.
yep! intentional
zzmp
suggested changes
Aug 23, 2022
| @@ -63,24 +64,25 @@ function useComputeSwapInfo(routerUrl?: string): SwapInfo { | |||
| useMemo(() => [currencyIn, currencyOut], [currencyIn, currencyOut]) | |||
| ) | |||
|
|
|||
| // Compute slippage and impact off of the trade so that it refreshes with the trade. | |||
There was a problem hiding this comment.
Retain the comments on L66-67 (or move them to useSlippage).
src/hooks/usePriceImpact.ts
Outdated
| toString: () => toHumanReadablePercent(percent), | ||
| } | ||
| : undefined | ||
| }, [trade]) |
zzmp
approved these changes
Aug 23, 2022
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uniswaplabs.atlassian.net/browse/DE-117
Shows PI even when unable to fetch a stablecoin price impact value.