Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow less than signed amount for swaps #162

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: allow less than signed amount for swaps #162

merged 1 commit into from
Aug 23, 2022

Conversation

zzmp
Copy link
Contributor

@zzmp zzmp commented Aug 23, 2022

Allows a user to trade less than the signed amount in a swap.
Eg if a user allows 0.1 UNI to be swapped, this will allow 0.05 UNI to be swapped without requiring a new signature for the lesser amount.

@zzmp zzmp requested a review from ianlapham August 23, 2022 19:08
@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
widgets ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 7:08PM (UTC)

@vercel vercel bot temporarily deployed to Preview August 23, 2022 19:08 Inactive
Copy link
Contributor

@cmcewen cmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah makes sense

Copy link
Member

@ianlapham ianlapham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zzmp zzmp merged commit 4d80fab into main Aug 23, 2022
@zzmp zzmp deleted the lt-approval branch August 23, 2022 19:21
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants