fix: clean SwapProps and standardize event handler logic #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JFrankfurt
reviewed
Aug 30, 2022
Comment on lines
+13
to
+16
| } catch { | ||
| return false | ||
| } | ||
| return true |
There was a problem hiding this comment.
can replace these returns with a single finally block
There was a problem hiding this comment.
I think a finally block will always run, so it overrides the returned value from within the try-catch block.
JFrankfurt
reviewed
Aug 30, 2022
| export interface SwapProps | ||
| extends BrandingSettings, | ||
| FeeOptions, | ||
| SwapController, |
There was a problem hiding this comment.
is the swapcontroller removal here intentional? (sry if this should be obvious)
There was a problem hiding this comment.
Yes, it should only need supplied through the 'value' prop now
JFrankfurt
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.