feat: add wallet connection functionality #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: set up ui elements for wallet connect * set up account avatar function * structure connect wallet modal * more ui updates for wc modal * wip provider utils * mm connection wip * linter * semi-working MM connection flow * Implement Metamask connection * minor alignment css * Add WIP WC functionality * Refactor useprovider fxn * Add link to help center for nowallet * Clean up useProvider * Fix WalletConnect; need window.Buffer polyfill * Fix WC connection * Add mainnet RPC URL fallback constant * Leave TODOs for readability * Leave TODOs for readability * Another todo * Update yarn.lock * Update .nvmrc for new @node/types * Better modal layout UI * Only use wallet if wallet is active * Update yarn.lock * Should only use our own flow iff provider & callbacks not given * fix: refactor wallet connection components (#33) * Refactor connect wallet into a separate component, and rename connect wallet callbacks * Rename callbacks * Fixes from PRs * Remove fallback JSON RPC URL logic; move to separate PR * Move web3 connection-related hooks into new folder * Rename and move connect web3-related hooks * fix: move updating Web3Context into hook (#34) * wip * Move context s.t. context is not exposed * Clean commit * Connect eagerly on mount * Minor css * Move components to Wallet * Rename dialog buttons to wallet name * Put network conditional back (fallback not implemented yet) * Add back disabled prop * Use e.preventDefault to determine opening our connection flow * Clean up unused code * nit * Clean comments * Don't deactivate other wallets before activating this one * Update yarn.lock
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Add useENSAvatar from interface, WIP identicon * Only use gradient icon * Remove broken useENSAvatar hook for now * nit: update comments
…b3-react (#38) * Add wip WC QR code; broken on second load * wip: display_uri not fired on second load * Clean code * Add support for both tile & popup WalletConnect * wip: use atom to save QR code between dialog close * Add persisting QR code * Update web3-react, wip handle errors * broken: * Add better RPC URL from props * Clean up code * Handle errors * Clean up URI listeners * Clean up code * Update yarn.lock * Undo force-changes to yarn.lock * Nit * Nit * Address PR comments * nit: rename useConnect handler * remove reportError for new w3r * add } * Rename hooks
* Use w3r's provider * Use provider instead of library * reformat * Finalize changes * Update useWeb3React imports * Rename file * PR review fixes * Remove useConnectCallback fxn * Revert w3r/network version
* feat: add fallback mainnet JSON RPC endpoint * Add better chainId support * Clean up code * nit: remove console .log * PR review updates * Remove console logs
* fix: use safer QR image * Use svg, change width * nit * fix: check staleness before setting state * fix: color match qr code * nit Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
…ur built-in flow" This reverts commit ba31255.
ianlapham
reviewed
Aug 2, 2022
ianlapham
reviewed
Aug 3, 2022
| @@ -40,32 +42,36 @@ function getTransactionFromMap( | |||
| return | |||
| } | |||
|
|
|||
| // SwapProps also currently includes props needed for wallet connection, since the wallet connection component exists within the Swap component | |||
| // TODO(kristiehuang): refactor WalletConnection outside of Swap component | |||
There was a problem hiding this comment.
#123 - let me know if this PR makes sense
Wanted to pull wallet connection out of the Swap component since it's separate concerns -- and also makes it slightly easier to build Buy/Donate/etc widgets in the future
ianlapham
reviewed
Aug 3, 2022
ianlapham
reviewed
Aug 3, 2022
kristiehuang
commented
Aug 3, 2022
vm
approved these changes
Aug 3, 2022
JFrankfurt
approved these changes
Aug 4, 2022
* wip tests; timeout? * write tests * Revert yarn.lock * Update tests * add newline * fix: do not log failed connection after unmount * Address PR review * move hardhat account to const * resolve provider toolbar flakiness Co-authored-by: Zach Pomerantz <zzmp@uniswap.org>
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding wallet connection functionality to widget! This means that every prop is now optional; a new integrator can now see a fully functional swap widget via
<SwapWidget />😀Remaining PRs that need reviews:
Breaking changes:
Other API changes: