fix: token dropdown balances should use 4 sigfigs #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JFrankfurt
suggested changes
Jun 30, 2022
| @@ -111,7 +108,7 @@ function TokenOption({ index, value, style }: TokenOptionProps) { | |||
| </Column> | |||
| </Row> | |||
| <TokenBalance isLoading={Boolean(account) && !balance}> | |||
| {balance?.greaterThan(0) && formatCurrencyAmount(balance, 2, i18n.locale)} | |||
There was a problem hiding this comment.
I think this should just be updated to 4 in the formatCurrencyAmount call. We use this same function for currency amount formatting throughout the codebase, and switching single numbers to use other formatting methods will lead to inconsistency.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, token dropdown only used 2 sigfigs (i.e. token balance of 1234 would get displayed as 1200)
Use 4 sigfigs to standardize with interface.