fix: use back button instead of X #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JFrankfurt
reviewed
Jul 5, 2022
src/components/Button.tsx
Outdated
| @@ -63,7 +63,7 @@ interface IconButtonProps { | |||
| export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps & ComponentProps<typeof BaseButton>>( | |||
| function IconButton({ icon: Icon, iconProps, ...props }: IconButtonProps & ComponentProps<typeof BaseButton>, ref) { | |||
| return ( | |||
| <SecondaryButton {...props} ref={ref}> | |||
| <SecondaryButton {...props} ref={ref} style={{ transform: 'translateY(1.75px)' }}> | |||
There was a problem hiding this comment.
put this in a styled wrapper instead of doing the inline style
nit - is it possible to accomplish this with some other tool? translate can be a little unexpected. It's better to use margin/padding/positioning in most cases. Not important to figure this out if you're busy.
JFrankfurt
approved these changes
Jul 5, 2022
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use an X icon to close dialog tabs, which creates a double X when the widget is hosted in an integrator modal.
Previously:
Now:
