feat: add autorouter API URL param #54
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…widgets into feat/auto-router-params
kristiehuang
changed the title
src/hooks/useClientSideV3Trade.ts
Outdated
| @@ -23,6 +23,7 @@ const DEFAULT_GAS_QUOTE = 2_000_000 | |||
| * @param amountSpecified the exact amount to swap in/out | |||
| * @param otherCurrency the desired output/payment currency | |||
| */ | |||
| // TODO: delete this function & deprecate it after swapping out USDC usage for SOR | |||
There was a problem hiding this comment.
will do this in a separate PR
There was a problem hiding this comment.
after swapping out USDC usage for SOR
What is this referring to?
There was a problem hiding this comment.
useUSDCPrice still uses useV2Quoter & useV3Quoter to calculate the price in USDC of the input currency - but now that we have a multichain SOR, we can deprecate those in favor of using SOR
There was a problem hiding this comment.
#58 (edit: i've merged that into this branch)
kristiehuang
changed the title
| amount: debouncedAmountSpecified, | ||
| tradeType, | ||
| routerUrl, | ||
| provider: library as JsonRpcProvider, |
There was a problem hiding this comment.
should we somehow verify that library is in fact a jsonrpcprovider instead of casting?
There was a problem hiding this comment.
and throw error if not
There was a problem hiding this comment.
library is of type (JsonRpcProvider & { provider?: ExternalProvider }) | Web3Provider and Web3Provider extends JsonRpcProvider
There was a problem hiding this comment.
so we should be good
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The Swap Widget computes the optimal trade route by running the @uniswap/smart-order-router package locally in the browser. This can take a few seconds to load & is slow.
Provider needs to support eth_feeHistory