fix: clientside router should use existing JsonRpcProvider obj #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kristiehuang
commented
Jul 12, 2022
| } else { | ||
| return value | ||
| } | ||
| })})` |
There was a problem hiding this comment.
L24-38 are the default serialization fxn from rtk-query; I added extra case for our nonserializable provider arg
kristiehuang
changed the title
zzmp
reviewed
Jul 13, 2022
| @@ -15,9 +18,29 @@ const DEFAULT_QUERY_PARAMS = { | |||
| protocols: protocols.map((p) => p.toLowerCase()).join(','), | |||
| } | |||
|
|
|||
| const serializeRoutingCacheKey: SerializeQueryArgs<any> = ({ endpointName, queryArgs }) => { | |||
| // same as default serializeQueryArgs, but we add extra case if key is our non-serializable JsonRpcProvider | |||
| return `${endpointName}(${JSON.stringify(queryArgs, (key, value) => { | |||
There was a problem hiding this comment.
I don't think you still need to serialize this, now that you've disabled serialization checks.
kristiehuang
added a commit
that referenced
this pull request
Jul 21, 2022
* wip: feat: add autorouter param * feat: add routerAPIBaseURL prop [wip] * remove V3 quoters for useBestTrade * feat: [wip] add rtk-query createAPI logic * style(lint): lint action with ESLint * feat: rename useBestTrade to useRouterTrade * Add routingApi slice reducer to store * use baseURL in API fetch * use string type instead of URL type * fix: use isFetching for trade state * nit: remove comments * Disable eslint for SOR import * nit: add comments for router provider * use activeWeb3React for router provider * style(lint): lint action with ESLint * nit * nit: fix lint about React hooks * nit: import comments * remove jank logic * fix: undefined chainId * fix: use provider connection URLs for router provider * nit: comments * feat: combine useRouterTrade & useRoutingAPITrade * nit: comments * fix: rename params & address PR comments * lint: type import SOR * remove comments + address PR * Remove 'useClientSideRouter' param * fix: clientside router should use existing JsonRpcProvider obj (#57) * [wip] feat: use provider obj in routingApi * remove serialization check * update comments * remove comment * update fxn docs * nit: fix serializeQueryArgs type * pr review * nit: remove comment * Add comments * fix: check currency chainid only if token inputted * feat: remove deprecated v2v3 quoters in useUSDCPrice (#58) * style(lint): lint action with ESLint * fix: Use clientside router for USDC prices * fix: reolve circular dependency * style(lint): lint action with ESLint * fix: widget should not rerender on every new quote * currentdata * add cosmos routerUrl param * fix: replace fetchBaseQuery * linter Co-authored-by: Lint Action <lint-action@uniswap.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reinstantiating provider obj from providerUrl, we want to pass in our existing JsonRpcProvider obj to routingApi. While rtk-query will cache args, it doesn't destroy the provider args - meaning our javascript garbage collector will collect it, which mean it may live in memory for longer than we want. (??)
Since we don't need time-travel debugging nor persistence, we can store non-serializable objects in state.
serializeQueryArgsfxn to generate a query cache key