Add improved support for mobile platforms #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mobile support v1
Add mobile support (WIP)
aleksandrasdzikia
requested review from
vincent-unity and
vaidasma
and removed request for
aleksandrasdzikia
vaidas-unity
changed the title
There was a problem hiding this comment.
Thanks Vaidas for adding these features.
I only checked that there were no regressions regarding the older features, but I had an issue after trying the following steps:
- I created a new project with Editor version 2020.2.0a7.826 (trunk revision cea774d83c47), that did not have mobile support installed
- I placed a cube with a custom unlit shader, and built the scene using the script from https://docs.unity3d.com/2020.1/Documentation/ScriptReference/BuildOptions.DetailedBuildReport.html
- I added to the project BuildReportInspector revision c5164bb (I installed it from my disk, where I had checked out the revision)
- I clicked Window/Open Last Build Report
- I got the following error displayed 999+ times in the console:
The appendix file does not exist at C:\unity-projects-current\wil-projects\check-build-report-mobile-pr\Assets/BuildReports/Mobile\b9761b87b7495474dbd4e42ef065a9cd. UnityEngine.Debug:LogError (object) Unity.BuildReportInspector.Mobile.MobileHelper:LoadMobileAppendix (string) (at C:/source-code/from-github-unity/BuildReportInspector/com.unity.build-report-inspector/Editor/Mobile/MobileHelper.cs:85) Unity.BuildReportInspector.BuildReportInspector:get_mobileAppendix () (at C:/source-code/from-github-unity/BuildReportInspector/com.unity.build-report-inspector/Editor/BuildReportInspector.cs:47) Unity.BuildReportInspector.BuildReportInspector:OnInspectorGUI () (at C:/source-code/from-github-unity/BuildReportInspector/com.unity.build-report-inspector/Editor/BuildReportInspector.cs:176) UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&) (at C:/unity-pr2/Modules/IMGUI/GUIUtility.cs:189)
Can you please add something to avoid such issues?
Thanks a lot also for having added tests, that's very helpful.
Fixed this issue, thanks for taking your time to test it. |
Thanks for all the fixes, to me the pull request looks good to merge :) |
|
Merging. Will request additional QA testing on master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
This PR extends the functionality of the BuildReportInspector package by adding improved support for Android and iOS platforms:
Release Notes:
Add improved support for iOS and Android.
Fix #1 - incomplete Assets list shown when there are many entries.
Fix .NET 3.5 support.
Testing status:
Manual testing - in progress (internal QA, ask @vaidas-unity for document link).
Automated tests - TBA.
Overall Product Risks:
Technical Risk: 2
Halo Effect: 2