Fix SpatialMenuElement warning present when entering play-mode #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a missing component on an object in the SpatialMenu prefab
mtschoen-unity
approved these changes
Mar 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix SpatialMenuElement warning present when entering play-mode, due to a missing component on an object in the SpatialMenu prefab. This warning wasn't present outside of play-mode. This fix removes the abstract SpatialMenuElement component from one of the "Text" gameObjects in the SpatialMenu prefab hierarchy.
Testing status
Tested in various scenarios, and wasn't able to reproduce the issue.
Technical risk
Medium. Due to the SpatialMenu prefab being re-serialized, there could be unforeseen minor visual changes. That said, I didn't see any visual difference present when testing.
Comments to reviewers
Enter play-mode, and you no longer see the warning "The class named 'UnityEditor.Experimental.EditorVR.SpatialMenuElement' is abstract. The script class can't be abstract!
UnityEditor.Experimental.EditorVR.Core.EditingContextManager:Awake()" logged from the DefaultScriptReferences class' Create() function.