Backwards Compatibility #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename prefab fields to work properly in 2018.1 and below; Find-replace all on: - m_SourcePrefab -> m_ParentPrefab - m_IsPrefabAsset -> m_IsPrefabParent - m_CorrespondingSourceObject -> m_PrefabParentObject
dunity
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ensure that EditorXR works in older version of Unity, starting with 2017.3
Testing status
Basic smoke test passed in 2017.3.0f3, 2017.4.22f1, 2018.1.0f2, 2018.2.21f1, and 2018.3.7f1.
Technical risk
Low -- Only changes serialized files, and only replaces field names with older versions, which have working upgrade paths
Comments to reviewers
The fist-time setup in 2017.3 is a little broken because of Text Mesh Pro. The "Import TMP Essentials" step fails, but if you can get those files from elsewhere, EditorXR works fine.
I had to revert the Spatial Menu prefab back to its state before #540 because the process for going from 2018.3 to earlier versions is not as straightforward. I removed the missing script reference before converting the prefab, so it shouldn't re-introduce that issue.