Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SceneEV100 indicator when rescaling and add a shadow to text #1495

Merged
merged 3 commits into from Aug 5, 2020

Conversation

FrancescoC-unity
Copy link
Contributor

Fix for https://fogbugz.unity3d.com/f/cases/1266974/

Also other than the bug, added a shadow to the text as suggested by Pierre

ShadowedText

Zoomed:

ShadowedTextBig

What I tested: Rescaled the scene view a lot, reset RTHandle (set viewport to biggest since opening) and rescaled again. Indicator is correct and text displayed is matching the color on screen.

The newly added shadow is there

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Copy link
Contributor

@TomasKiniulis TomasKiniulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking together with Francesco can't repro the issue anymore. Marking this as approved as nothing else seems to be affected and already tested before by Francesco anyway

@sebastienlagarde sebastienlagarde merged commit 1cda216 into HDRP/staging Aug 5, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/ev100-debug-rt-handle-fix branch August 5, 2020 07:59
@sebastienlagarde sebastienlagarde mentioned this pull request Sep 3, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants