Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Hdrp/staging #1733

Merged
merged 56 commits into from
Sep 3, 2020
Merged

Merge Hdrp/staging #1733

merged 56 commits into from
Sep 3, 2020

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Sep 1, 2020

Purpose of this PR


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

pmavridis and others added 30 commits August 4, 2020 09:41
Fix case 1264632 - HDRP Lit comes with Coat Mask in the stack, which is disabled by default
* Fix SceneEV100 RTHandle and add a shadow to text

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added a new debug mode for cluster visualization where we visualize a slice instead of opaque objects.

* Update changelog
* Set atlas viewport before softness in request is set

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…d Scene is disabled (#1504)

* Create emissive mesh if not created but is requested.

* Changelog

* Remove unnecessary create function call

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
… they were not (#1509)

* Prevent OnEnable probes to be marked as rendered if actually they were not rendered.

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Avoid the sun icon to be cut

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…1506)

* Don't actually set the game object -1 as layer

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ositor .asset file (#1499)

* Do not allow manual edit/reset of values in the compositor profile .asset file

* Also disable edits on already existing compositor .asset files

* Fix issue when the user deletes the composition graph or .asset in runtime

* Rename function name

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…#1489)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix flickering layer in graphics compositor

* Revert unintentional changes in the HDRenderPipeline file

* Proper fix after more tests

* Avoiding cloning children attached to the layer camera

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Don't update legacy shape with HDRP vals for discs

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Various doc fix

* Added Volume snippet and filled out a few properties

* Added .md extension to internal docs link not in toc

* Update documentation

Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
* Fix issues with texture atlas always updating

* Clean a bit

* Changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
Motion blur with alembic animation
…ed-velocity

Added precomputed velocity test
… into HDRP/staging

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
…ras in HDRP [Depends on C++] (#1098)

* Fix an issue where world space UI was not emitted for reflection cameras in HDRP

* Update changelog

* Added proper ifdef for 2020.2
…exture cookies update. (#1527)

* Fixed the update condition of cookie atlas and added doc for render texture cookies update.

* Update changelog

* Update doc based on review feedback
JulienIgnace-Unity and others added 12 commits August 25, 2020 14:32
* Fixed a bug related to light cluster invalidation

* unnecessary allocation removed

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Added ray traced reflection support for the render graph version of the pipeline.
Enabled the reflection tests for the render graph variant.

* Added render graph support of RTAO and required denoisers.

* Added render graph support of RTGI.

* Supporting RTSSS and Recursive Rendering in the rendergraph mode.
Enabling RR, RTSSS and other tests for render graph.

* Supporting RT and screen space shadow for render graph
Enabling the remaining dxr (non-pt) tests

* adressing review corrections

* Removing some unwanted memory allocations

* unwanted params

* nullref fix
* Implementation of custom post processes in render graph

* Fixed input depth for DoF with Render Graph

* Re-enabled 8103 for render graph.

* Fixed depth clear in RG

* Fixed post process history reset with RG

* Added exposure debug to render graph
…er-parametrization

Hdrp/fix/terrain layer parametrization
sebastienlagarde and others added 10 commits September 2, 2020 00:04
* Enable AOV API at runtime

* Add an info message to say that it is required to enable runtime AOV API

* fix indent

* Fix issue with AOV depth buffer export

* Update CHANGELOG.md

* rename DebugRemap to DebugDepthRemap

* update rendegraph

* Update HDProfileId.cs

* update documentation based on feedback
* Shadow doc update

* Small change.

* Another small change.

* PR comments

* Removed links to github

Co-authored-by: JordanL8 <lewis.jordan@hotmail.co.uk>
* Check if we need to update the texture if it has been already cached.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
… probe is at same camera location (#1537)

* Offset a bit reference position if it is exactly the same as proxy position.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Add macro helper

* Add parenthesis
* HTile buffer removal

* Changelog
* Supporting SSGI in the render graph mode.

* review corrections

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@sebastienlagarde sebastienlagarde marked this pull request as ready for review September 3, 2020 13:55
@sebastienlagarde
Copy link
Contributor Author

Yamato is green with the usual error from master.

@sebastienlagarde sebastienlagarde merged commit d3104b2 into master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants