Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x.x] [VFX] Batch of backport for 7.5.2 #2777

Merged
merged 65 commits into from
Nov 29, 2020
Merged

[7.x.x] [VFX] Batch of backport for 7.5.2 #2777

merged 65 commits into from
Nov 29, 2020

Conversation

PaulDemeulenaere
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere commented Nov 27, 2020 •
edited

Purpose of this PR

  • VFX : Debug material view were rendering pink for albedo.(case 1290752)
  • GPU Evaluation of Construct Matrix
  • Random Per-Component on Set Attribute in Spawn Context Case 1279294
  • Fix corrupted UI in nodes due to corrupted point cache files Case 1232867
  • Fix InvalidCastException when using byte properties in point cache files Case 1276623
  • Forbid creation of context in VisualEffectSubgraphBlock through edge dropping. No context should be allowed.
  • Fix shadows not being rendered to some cascades with directional lights Case 1229972
  • Fix Case 1114281
  • Fix Case 1268354
  • Fix VFX Graph window invalidating existing Undo.undoRedoPerformed delegates.
  • Fix for VisualEffect prefab override window Case 1242693
  • Fix Case 1281861
  • Unexpected exception while installing samples inside an URP project Case 1280065
  • Fix edited operator being collapsed Case 1270517
  • Fix View Space Position is VFX Shadergraph Case 1285603
  • Fix Case 1255182

Testing status

Manual 🟢
Awaiting for yamato ⏳

iTris666 and others added 30 commits July 21, 2020 09:40
@iTris666 @julienf-unity
Vfx/fix/sgoperator create context drag (#28)
67ca602
@iTris666 @julienf-unity
Vfx/fix/context no blocks (#27)
f4e38ea
@PaulDemeulenaere @julienf-unity
PropertyBinder : Minor Fixes #29
d8ad824
@julienf-unity
Fix strips outputs, spawnIndex and default metallic value
6514532
@PaulDemeulenaere @julienf-unity
[Fix] Disable reset option (#41)
1c76c10
@PaulDemeulenaere @julienf-unity
Fix minor issue with PreviousPropertyBinder (bis) #31
3f567a8
@julienf-unity
Fix culture issues when generating attributes defines in shaders (#40)
a24f243
@PaulDemeulenaere @julienf-unity
[PropertyBinder] Move Update to LateUpdate (#38)
2e7166c
@julienf-unity
Easy Wins (Small Workflow / Cosmetic fixes) (#37)
8fd9015
@JordanL8 @julienf-unity
Vfx/docs/compatability disclaimer (#43)
cce9131 
* Added compatability disc

* Updated format.
@iTris666 @julienf-unity
Simulate headers on enum values in SlotContainerEditor (#49)
e46ef12
@julienf-unity
Fix 1246738 - Remove incorrect propagation of expression flags
5679561
@PaulDemeulenaere @julienf-unity
[VFX] Fix crash on NDA platform : 100_Fog (#1265)
cb1ab75 
* Disable noperspective flag for driver issue on NDA platform

* Add minor note to track the actual issue

* Isolate on concerned platform

* Change define condition
@julienf-unity
Change description in package.json to reflect VFX is not out of previ…
0ee6d1f 
…ew with URP and mobile
@iTris666 @julienf-unity
Simplify linear drag (#67)
b701b35 
* Simplify linear drag

* Fix warning
@julienf-unity
Update ref images
fcd2058
@julienf-unity
Update assets
1fcaef2
@julienf-unity
Fix changelog
4e1e376
@julienf-unity
Merge remote-tracking branch 'graphics/7.x.x/release' into vfx/7.x.x-…
40b8ef2 
…staging
@JordanL8 @julienf-unity
Vfx/docs/system requirements (#69)
bdd22fb 
* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
@iTris666 @julienf-unity
Fix position of block creation window (#72)
fb978d0
@iTris666 @julienf-unity
Call recreateCopy after recusion test not before. #52
74829a2
@PaulDemeulenaere @julienf-unity
Fix Prefab Highlight for initial event name toggle & override #71
e6d03c3
@iTris666 @julienf-unity
Uniquify create visual effect gameobject name. Standard behaviour. #75
f88d29b
@julienf-unity
Vfx/fix/1246989 normals and scale (#81)
ec153ec
@julienf-unity
Fix Texture2DArray and Cubemap exposition from sg in output mesh cont…
c6dbe4f 
…ext (#76)
@JordanL8 @julienf-unity
Added render pipeline compatability table (#87)
d3c0005 
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
@iTris666 @julienf-unity
Fix square complexity on parameter to serialized property matching
cb5c063
@iTris666 @julienf-unity
Fix vfx view not beeing framed at launch
50e00b1
@iTris666 @julienf-unity
Fix for the lookup of mixed values in the VisualEffectEditor with obj…
d8b513c
PaulDemeulenaere and others added 17 commits November 26, 2020 17:42
@PaulDemeulenaere @julienf-unity
Fix Sample installation in URP #122
76ef883
@iTris666 @julienf-unity
Reset the indentLevel at the end of VisualEffectEditor, also better c… (
e1967fe 
#127)
@iTris666 @julienf-unity
Un edit nodes that are collapsed (#133)
8c9f73c 
* Un edit nodes that are collapsed

* Update CHANGELOG.md

* Update CHANGELOG.md
@iTris666 @julienf-unity
Add one pixel to height in non wide mode so that margin is equal to w…
27ad35a 
…ide mode. (#145)
@ludovic-theobald @julienf-unity
Fix 1285603 View and Object mode of Shadergraph position node don't r…
d299e63
@iTris666 @julienf-unity
Fix collapse exception and added automated test (#149)
91ad151
@iTris666 @julienf-unity
Small fix for collapse test
0d9fa6b
@ludovic-theobald @julienf-unity
Fix 1255182 Compile errors using Baked GI (default UV settings) / Out…
f7f2825 
…put Particle Mesh / Connected Attributes (#139)
@julienf-unity
Fix suitableContext for subblocks not being serialized
0821fd5
@julienf-unity
Remove Debug Log
de6d925
@PaulDemeulenaere @julienf-unity
[HDRP] Fix debug view material (albedo/normal/...)
684a220
@julienf-unity
Fix changelog
e24437a
@julienf-unity
Fix compilation of expression tests
995705a
@julienf-unity
Fix shadow test ref images
98adcd3
@julienf-unity
Fix Non Uniform Scale test (remove physical sky)
0cc36eb
@PaulDemeulenaere
*Update HDRP_Debug reference image
bb5268e
@PaulDemeulenaere
*Rebuild all .vfx (HDRP by default)
2aea342
@PaulDemeulenaere PaulDemeulenaere changed the title [7.x.x] batch of backport for 7.5.2 [7.x.x][VFX] batch of backport for 7.5.2 Nov 27, 2020
@PaulDemeulenaere PaulDemeulenaere marked this pull request as ready for review November 27, 2020 16:25
@PaulDemeulenaere PaulDemeulenaere changed the title [7.x.x][VFX] batch of backport for 7.5.2 [7.x.x] [VFX] batch of backport for 7.5.2 Nov 27, 2020
@PaulDemeulenaere PaulDemeulenaere changed the title [7.x.x] [VFX] batch of backport for 7.5.2 [7.x.x] [VFX] Batch of backport for 7.5.2 Nov 27, 2020
@julienf-unity julienf-unity merged commit e94ad24 into 7.x.x/release Nov 29, 2020
@julienf-unity julienf-unity deleted the vfx/7.x.x-staging branch November 29, 2020 11:29
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Nov 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienf-unity julienf-unity Awaiting requested review from julienf-unity

Assignees
No one assigned
Labels
vfx
Projects
None yet
Milestone
No milestone
6 participants
@PaulDemeulenaere @julienf-unity @iTris666 @JordanL8 @gabrieldelacruz @ludovic-theobald