Fix quality settings UI and shadow mask UI #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2020
sebastienlagarde
added
backported-7.x
backported-8.x
and removed
needs-backport-8.x
labels
sebastienlagarde
changed the title
com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.cs
Outdated
Show resolved
Hide resolved
JulienIgnace-Unity
suggested changes
Apr 15, 2020
Fixed |
JulienIgnace-Unity
approved these changes
Apr 15, 2020
|
|
@iM0ve could you check if the error happen in HDRP/staging already? and also if this error happen with any other option (I don't think it is related to shadowmask, but a more general issue). thanks |
|
Yes appears to be non PR specific. Also on staging. I updated the comment by removing the issue. Also it happens with other checboxes like Ambient Occlusion, Volumetrics, etc |
iM0ve
approved these changes
Apr 15, 2020
sebastienlagarde
changed the title
This was referenced Apr 28, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix for : https://fogbugz.unity3d.com/f/cases/1232042/
+
Fix for : https://fogbugz.unity3d.com/f/cases/1232011/
It rely on C++ PR: https://ono.unity3d.com/unity/unity/pull-request/104532/_/graphics/quality-settings-ui
This PR hide shadow mask property in quality settings as well as realtime reflection probe property.
It also enable/disable UX correctly when Shadow Mask is support is disabled in HDRP asset.
Test:
Checked that behavior is correct when switching between different pipeline and with several pipeline in quality settings and switching to them. Yamato should handle the shadow mask still working part.
Testing status
Manual Tests: What did you do?
Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)
Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/78-ScriptableRenderPipeline
Any test projects to go with this to help reviewers?
Comments to reviewers
Notes for the reviewers you have assigned.