Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min version of SRP package to 2020.1b8 #326

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

sebastienlagarde
Copy link
Collaborator

@sebastienlagarde sebastienlagarde commented Apr 29, 2020

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
bump min version of SRP package to 2020.1b8
This is required by this PR: #122

to avoid this error:
D:\code\Graphics\com.unity.render-pipelines.high-definition\Runtime\RenderPipeline\HDRenderPipeline.cs(713,19): error CS0117: 'SupportedRenderingFeatures' does not contain a definition for 'overridesShadowmask'


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants